Make WordPress Core

Opened 7 years ago

Closed 4 months ago

Last modified 3 months ago

#41877 closed enhancement (fixed)

Caddy server support

Reported by: viliamkopecky's profile viliamkopecky Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version: 4.8.1
Component: Permalinks Keywords: has-patch needs-dev-note
Focuses: Cc:

Description

Caddy behaves mostly as nginx. But unknown $_SERVER['SERVER_SOFTWARE'] caused default permalinks options to include index.php. This patch replicates global $is_nginx variable to Caddy's context.

Attachments (1)

41877.patch (2.6 KB) - added by viliamkopecky 7 years ago.
adding and using of $is_caddy global variable

Download all attachments as: .zip

Change History (11)

@viliamkopecky
7 years ago

adding and using of $is_caddy global variable

#1 @JPry
7 years ago

  • Keywords has-patch added

#2 follow-up: @dd32
7 years ago

I wonder if it's about the time that we can assume that all web servers have rewrites available?

We could keep the iis7/apache checks as they expose methods to check.. but most other server environments DO support it today - and any future server is likely to support it too given how relied upon it is today.

#3 in reply to: ↑ 2 @johnbillion
7 years ago

  • Focuses administration removed
  • Keywords needs-refresh added

Replying to dd32:

I wonder if it's about the time that we can assume that all web servers have rewrites available?

We could keep the iis7/apache checks as they expose methods to check.

This sounds sensible.

#4 @swissspidy
4 months ago

#57986 was marked as a duplicate.

#5 @swissspidy
4 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Owner set to swissspidy
  • Status changed from new to assigned

What about CLI usage, Playground, or other unusual setups?

I‘d just add this patch for now & then revisit the suggested approach in a separate ticket.

This ticket was mentioned in PR #6096 on WordPress/wordpress-develop by @swissspidy.


4 months ago
#6

  • Keywords needs-refresh removed

#7 @swissspidy
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57612:

Permalinks: Detect Caddy web server support.

Support pretty permalinks when Caddy server is detected.

Props swissspidy, mukesh27, sadpencil, cfinnberg, viliamkopecky.
Fixes #41877.

#8 @swissspidy
4 months ago

In 57613:

Coding Standards: Add missing fullstop to docblocks in wp-includes/vars.php

Follow-up to [57612.

Props mukesh27.
See #41877.

#10 @stevenlinx
3 months ago

  • Keywords needs-dev-note added

as a misc note

Note: See TracTickets for help on using tickets.