Missing Break Statement In class-pclzip php file

[adnan.limdi]

Missing Break statement in switch case conditions it is PHP warning.

[adnan.limdi]

Missing break Statement in switch case.

[jrf]

@adnan.limdi Could you provide the error message and a backtrace of it please ?

[adnan.limdi]

Replying to jrf:

@adnan.limdi Could you provide the error message and a backtrace of it please ?

@jrf i found warning when dubug using php code stander this file in switch case statement. and i got this message : Break Statement is missing.

[johnbillion]

A missing break statement does not automatically indicate an error in the code. An expression can match multiple case conditions and intentionally fall through (this happens in the large switch statement in the map_meta_cap() function).

In this case, it does look like the break statement is missing, but I don't believe there is a reason to "fix" this unless a bug can be identified.

[dd32]

This looks to be intentional to me.

PCLZIP_OPT_BY_EREG is deprecated, so it overwrites PCLZIP_OPT_BY_EREG with PCLZIP_OPT_BY_PREG in the args array, and then performs the validation for the parameters for ..PREG which is what now happens when you use ..EREG

Code in question with more context:
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-pclzip.php?marks=1566-1579#L1558

It's also worth noting, that PclZip is not a WordPress library, it's home is over at ​http://www.phpconcept.net/pclzip and bugs in it can be reported directly to the author. Over the years we've made some updates to the library for PHP compatibility, but that's it.

Unless this is causing a PHP Warning or related message or an actual bug, I'm marking this as invalid. A warning from a code sniffer or similar tool isn't enough of a reason to change it IMHO.

[adnan.limdi]

@dd32 Thanks for providing information for that. I take care next time about PHP warning.

[jrf]

@johnbillion @dd32 Should an // Intentionally falling through to next case. comment be added maybe to make it indisputable that this in the intended behaviour ? /cc @DrewAPicture