WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41897


Ignore:
Timestamp:
09/16/2017 08:47:53 PM (2 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41897 – Description

    initial v1  
    1 With the introduction of CodeMirror in #12423 the Custom CSS functionality in the Customizer was updated to make use of the new code editor. However, the initial integration in [41376] was not done in a way that would allow for the code to be re-used in other places (such as adding other instances of code editor controls) or to facilitate plugins to extend and customize how the Custom CSS control behaves (currently core and [https://github.com/Automattic/jetpack/issues/7776 Jetpack conflict]).
     1With the introduction of CodeMirror in #12423 the Custom CSS functionality in the Customizer (#35395) was updated to make use of the new code editor. However, the initial integration in [41376] was not done in a way that would allow for the code to be re-used in other places (such as adding other instances of code editor controls) or to facilitate plugins to extend and customize how the Custom CSS control behaves (currently core and [https://github.com/Automattic/jetpack/issues/7776 Jetpack conflict]).
    22
    33I suggest that the code that is currently hard-coded for the `custom_css` textarea control be abstracted into a general `WP_Customiz_Code_Editor` control which then can be used for Custom CSS and also for adding code editing for anywhere else that a plugin may want it. It can then be cleanly extended by Jetpack.