Changes between Version 1 and Version 4 of Ticket #41897
- Timestamp:
- 09/16/2017 09:03:36 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #41897
- Property Keywords has-patch added
- Property Owner set to westonruter
-
Property
Status
changed from
new
toaccepted
-
Ticket #41897 – Description
v1 v4 1 1 With the introduction of CodeMirror in #12423 the Custom CSS functionality in the Customizer (#35395) was updated to make use of the new code editor. However, the initial integration in [41376] was not done in a way that would allow for the code to be re-used in other places (such as adding other instances of code editor controls) or to facilitate plugins to extend and customize how the Custom CSS control behaves (currently core and [https://github.com/Automattic/jetpack/issues/7776 Jetpack conflict]). 2 2 3 I suggest that the code that is currently hard-coded for the `custom_css` textarea control be abstracted into a general `WP_Customiz _Code_Editor` control which then can be used for Custom CSS and also for adding code editing for anywhere else that a plugin may want it. It can then be cleanly extended by Jetpack.3 I suggest that the code that is currently hard-coded for the `custom_css` textarea control be abstracted into a general `WP_Customize_Code_Editor` control which then can be used for Custom CSS and also for adding code editing for anywhere else that a plugin may want it. It can then be cleanly extended by Jetpack.