WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#41898 closed enhancement (fixed)

"Back to {taxonomy}" should be a taxonomy label

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: good-first-bug has-patch commit
Focuses: administration Cc:

Description

On the term editing screen, a link with the phrase ← Back to {taxonomy} is displayed after a term has been updated. This text should be moved into a taxonomy label so that more accurate translations can be provided for each taxonomy.

Ref: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-tag-form.php?rev=40668&marks=78-79#L72

Attachments (4)

Screen Shot 2017-09-17 at 12.02.18 PM.png (108.6 KB) - added by Kenshino 4 years ago.
term label
41898.diff (2.1 KB) - added by benoitchantre 4 years ago.
41898.2.diff (2.1 KB) - added by benoitchantre 4 years ago.
post-updated-message.png (7.6 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (14)

#1 @Kenshino
4 years ago

Hey @johnbillion so looks like from that line of code it's already pulling the text from a term label.

Are you suggesting the entire line 'Back to {taxonomy} should be entirely replaced with a label? So that the text 'Back to' can also be defined in a label?

https://core.trac.wordpress.org/attachment/ticket/41898/Screen%20Shot%202017-09-17%20at%2012.02.18%20PM.png

#2 @johnbillion
4 years ago

Yep that's right, the complete string should be a taxonomy label.

@benoitchantre
4 years ago

#3 @benoitchantre
4 years ago

  • Keywords has-patch added; needs-patch removed

Let me know if everything looks good, this is my first patch :-)

This ticket was mentioned in Slack in #core by benoitchantre. View the logs.


4 years ago

#5 @ramiy
4 years ago

I'm not sure this string should be added to taxonomy labels. If any, we should change the taxonomy update message to match the post update message.

This ticket was mentioned in Slack in #core by benoitchantre. View the logs.


4 years ago

#7 @benoitchantre
4 years ago

  • Keywords commit added

#8 @SergeyBiryukov
4 years ago

I agree with @johnbillion that it should be a taxonomy label.

We tend to avoid post type or taxonomy names in generic strings due to i18n concerns, see ticket:17609:3 and ticket:19099:1. Back to %s is a bad example and exactly the kind of string we'd like to avoid :)

In Russian, we currently have to translate it as an equivalent of Back to "%s" screen instead of using proper declensions.

#9 @johnbillion
4 years ago

  • Component changed from I18N to Taxonomy

#10 @johnbillion
4 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 41618:

Taxonomy: Introduce a back_to_items taxonomy label.

This is used after updating a taxonomy term in the link to return to the term listing screen.

Props benoitchantre

Fixes #41898

Note: See TracTickets for help on using tickets.