wp-load.php: comment for error reporting levels

[sasagar]

Yes, looks good to me.

I think this can just be committed, not much to break here.

[schlessera]

Thanks for the ticket and patch, @sasagar !

If we go ahead and add an additional comment, we should also make sure it provides added value as well.

How about something like this:

/*
 * Initialize error reporting to a known set of levels.
 * 
 * This will be adapted in wp-includes/load.php based on the WP_DEBUG setting.
 * @see http://php.net/manual/en/errorfunc.constants.php List of known error levels.
 */ 
error_reporting( E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_ERROR | E_WARNING | E_PARSE | E_USER_ERROR | E_USER_WARNING | E_RECOVERABLE_ERROR );

[sasagar]

@schlessera

Thanks for suggesting!
Nice one isn't it!?

I agree to add your comment, this time!

This ticket was my first one at WordCamp Tokyo. So I'm not sure this was the good ticket.
I'm so happy to get any feedback!

Replying to schlessera:

Thanks for the ticket and patch, @sasagar !

If we go ahead and add an additional comment, we should also make sure it provides added value as well.

How about something like this:

/*
 * Initialize error reporting to a known set of levels.
 * 
 * This will be adapted in wp-includes/load.php based on the WP_DEBUG setting.
 * @see http://php.net/manual/en/errorfunc.constants.php List of known error levels.
 */ 
error_reporting( E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_ERROR | E_WARNING | E_PARSE | E_USER_ERROR | E_USER_WARNING | E_RECOVERABLE_ERROR );

[sasagar]

added the

[sasagar]

@schlessera
Sorry for long time no see.

I changed the patch file as you suggested. (I couldn't type description completely. :( )

Would you check for that anytime you can.
I hope it would work.

[jorbin]

In 50914:

Bootstrap/Load: Improve docs for error reporting

Make it clearer that wp_debug_mode will change this based on the WP_DEBUG constant and also make it clearer where this list comes from.

Props sasagar, schlessera, jorbin.
Fixes #41902.