WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#41904 closed defect (bug) (fixed)

Html Invalid

Reported by: adnanlimdi's profile adnan.limdi Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Image closed tag missing in class-wp-plugin-install-list-table file line no 535.

Attachments (1)

img-closetag-missing.patch​ (614 bytes) - added by adnan.limdi 7 years ago.

Download all attachments as: .zip

Change History (6)

@adnan.limdi
7 years ago

#1 @adnan.limdi
7 years ago

  • Keywords has-patch added

#2 follow-up: @Soean
7 years ago

Hey Adnan,

The img element is a void element. An img element must have a start tag but must not have an end tag.

Source: ​http://w3c.github.io/html-reference/img.html#img

The '/' at the end of a void element was just necessary in the old XHTML.

#3 in reply to: ↑ 2 @adnan.limdi
7 years ago

Hello @Soean you are right but we are follow image close tag for every file except this files and
Whereas <img src="smiley.gif" alt="Smiley face" height="42" width="42"/>, this code is for XHTML version.

#4 @SergeyBiryukov
5 years ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 5.5

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47493:

Administration: Add / character to <img> tag in WP_Plugin_Install_List_Table::display_rows().

While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.

Note: See TracTickets for help on using tickets.