Break statement missing in switch case in function.php file in wp-includes

[lalitpendhare]

Break statement missing in switch case in function.php file in wp-includes on line number 388 to 399

switch ( $token ) {
		case 's' :
			if ( $strict ) {
				if ( '"' !== substr( $data, -2, 1 ) ) {
					return false;
				}
			} elseif ( false === strpos( $data, '"' ) ) {
				return false;
			}
			break;
			// or else fall through
		case 'a' : break;
		case 'O' :
			return (bool) preg_match( "/^{$token}:[0-9]+:/s", $data );
			break;
		case 'b' : break;
		case 'i' : break;
		case 'd' :
			$end = $strict ? '$' : '';
			return (bool) preg_match( "/^{$token}:[0-9.E-]+;$end/", $data );
			break;

[ocean90]

Hello @lalitpendhare, thanks for your patch but the switch statement is correct as it is. There's no need for the break keyword after a return.

[lalitpendhare]

Hello @ocean90, thanks for your quick response and suggestion about break statement.

[SergeyBiryukov]

There's also no need for break after the "empty" cases here (case 'a', case 'b', case 'i'), as it will prevent them from falling through to the next case, which is what the current code is supposed to do.