WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#4191 closed enhancement (fixed)

major rework of wp-app.php

Reported by: eliast Owned by: ryan
Milestone: 2.3 Priority: high
Severity: normal Version:
Component: XML-RPC Keywords: app wp-app atom
Focuses: Cc:

Description

I have a done a ton of rework for the APP implementation. Most importantly, I have broken up the parser from the server.

There are many fixes as a result of the Atom Interop event at Google. But some of them include:

  • Better support for XHTML
  • More complete query results of entries in feed listings
  • Converted tabs to spaces
  • Added support for atom:published
  • Categories support (both XML document and set/update categories)
  • Improved Paging
  • Fixed draft support
  • Improved role/caps support
  • Fixed atomsvc+xml content type
  • Fixed Media Collection urls
  • Tested with our own test suite: http://svn.wp-plugins.org/wp-app/test

That's all for now.

Attachments (3)

wp-app.patch (27.3 KB) - added by eliast 7 years ago.
atomlib.php (10.1 KB) - added by eliast 7 years ago.
wp-app.php.diff (33.2 KB) - added by placey 7 years ago.
Patch to bring wp-app.php up to conformance with final Atompub spec

Download all attachments as: .zip

Change History (14)

comment:1 rob1n7 years ago

Just briefly looking at the atomlib.php, it says it requires PHP 5... WP has a minimum requirement of PHP 4.2, I believe.

comment:2 eliast7 years ago

rob1n, php5 is a long story. Language-wise it doesn't need php5, but there are differences in XML parsing between 4.2 and 6 that are hard to ignore. This is something we need to decide, although, I have been coding with the lowest common denominator in mind. That said, it works on my dreamhost account with php4.4.2 I think. We can always disable APP support if there's not enough XML support to maintain a stable endpoint. However, that shouldn't stop us from shipping it.

comment:3 foolswisdom7 years ago

  • Milestone changed from 2.4 to 2.3

comment:4 matt7 years ago

This patch is unreadable because of the needless tab -> spaces changes. Please keep things to WP's coding standards, and try to keep patches as succinct as possible.

eliast7 years ago

eliast7 years ago

comment:5 eliast7 years ago

  • Cc matt added
  • Summary changed from Major rework of wp-app.php to Not so major rework of wp-app.php

@matt,

I fixed the patch considerably to make it more readable. Please let me know if this is ready to be committed.

@rob1n,

The code has always been the same (so it works on php4). The only reason why I added php5 was because that's the parser I have tested and they do behave differently across versions depending on what you compiled php with. However, I'll work to make sure the XML parsing behavior is consistent across versions.

comment:6 foolswisdom7 years ago

Sam Ruby will be reviewing and testing the patch attached here
http://intertwingly.net/blog/2007/08/03/WordPress-AtomPub-and-PHP5#c1186424251

comment:7 josephscott7 years ago

  • Cc josephscott added

placey7 years ago

Patch to bring wp-app.php up to conformance with final Atompub spec

comment:8 placey7 years ago

  • Priority changed from normal to high
  • Summary changed from Not so major rework of wp-app.php to major rework of wp-app.php

Attached wp-app.php.diff that can be applied against the current version on the trunk. This should bring Atompub support up to the current and final release of the spec, but needs additional testing.

comment:9 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5951]) Bring in atomlib 0.4 and update wp-app to use it. Props eliast and placey. fixes #4191

comment:10 follow-up: foolswisdom7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

DD32 to wp-hackers:

Might not be a bug, But are you sure you wanted '.*/wp-app.php' ?
keeping in mind that str_replace only replaces literals, it doesnt support
regular expresions.

comment:11 in reply to: ↑ 10 josephscott7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to foolswisdom:

DD32 to wp-hackers:

Might not be a bug, But are you sure you wanted '.*/wp-app.php' ?
keeping in mind that str_replace only replaces literals, it doesnt support
regular expresions.

This was dealt with in #4887 and committed in [6004].

Note: See TracTickets for help on using tickets.