Image Widget Custom Link Target

[Nenad Obradovic]

Hi,

I think there is a small issue inside WP_Widget_Media_Image Class with link_target_blank option, when you render html code for this widget (code below) you only set target value to be _blank if this option is set in otherwise target value is empty and HTML validator mark this empty target value as error because that attribute can't be empty. Thanks

! empty( $instance['link_target_blank'] ) ? '_blank' : '',

Best regards,
Nenad

[westonruter]

You're right. Would you like to submit a patch?

For reference, here's a direct link to the code in question:

​https://github.com/WordPress/wordpress-develop/blob/88464ec/src/wp-includes/widgets/class-wp-widget-media-image.php#L244-L248

[Nenad Obradovic]

Fixed image widget target value

[subrataemfluence]

Good catch! Thanks for the ticket.

However, looking at HTML5 coding standard the only two values allowed for target attribute are _blank and _self.

Values like _top, _parent and <frame_name> are now deprecated in HTML5 standard.

​http://html.com/attributes/a-target/

The line in question is also checking only for the value _blank, keeping above in mind. So, how about we do not add the target attribute at all if the value is not _blank since _self is default if no target attribute is set.

I have uploaded a modified diff. Please let me know if this makes sense.

[westonruter]

@subrataemfluence Your patch is perfect. Exactly what I was envisioning.

[westonruter]

It looks like actually 41919.2.diff​ doesn't go far enough. There are other attributes, including class and rel that also should be omitted when empty. See 41919.3.diff​.

[westonruter]

In 41549:

Widgets: Omit attributes from an Image widget's link when they are empty.

Props subrataemfluence, Nenad Obradovic, westonruter.
See #39993.
Fixes #41919.

[subrataemfluence]

@westonruter Thank you! Also thank you for considering class and rel attributes as well :)

Replying to westonruter:

@subrataemfluence Your patch is perfect. Exactly what I was envisioning.

[westonruter]

#42010 was marked as a duplicate.