Opened 7 years ago
Closed 7 years ago
#41966 closed enhancement (fixed)
Add checkered grid to background of all media library images
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | good-first-bug has-patch |
Focuses: | ui, accessibility | Cc: |
Description
This issue is related to ticket #41948.
I noticed a few other places in the WordPress admin that we may want to include the checkered background. They have been listed in the attached screenshots. These screenshots have been manually adjusted with Chrome inspector tool to depict what the interface would look like with the checkered background.
Attachments (5)
Change History (16)
#2
@
7 years ago
Adding the checkered background for transparent images in Media Library was previously suggested in comment:35:ticket:33299 and decided against in comment:36:ticket:33299.
Maybe it's time to reconsider, consistency sounds good.
#3
@
7 years ago
What if we only showed the checkered background in places where the image appears on white?
#4
@
7 years ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to Future Release
#5
@
7 years ago
- Keywords has-patch added; needs-patch removed
- Resolution set to invalid
- Status changed from new to closed
#7
@
7 years ago
- Milestone changed from Future Release to 4.9
- Owner set to SergeyBiryukov
- Status changed from reopened to reviewing
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
7 years ago
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
7 years ago
#10
@
7 years ago
It looks like Insert Media modal is fine as is, as the background there is not white: insert-media-modal.png
Edit Image modal, on the other hand, does need the checkered background, as seen on attachment-details.png.
Applying the styles from [41569] to .imgedit-crop-wrap img
appears to work as expected.
The checkered background is already present in the 'featured image' image background. It is also being added in the media library modal, in 4.9 as per the other ticket mentioned. Including it elsewhere would create consistency across the WordPress admin, which I believe is a positive.