WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 6 hours ago

#41969 assigned task (blessed)

Ensure Gallery widget is styled properly across widget areas in bundled themes

Reported by: westonruter Owned by: davidakennedy
Milestone: 4.9 Priority: high
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch ui-feedback
Focuses: Cc:

Description

The Gallery widget (#41914) allows for image galleries to be added to widget areas. Many themes may not have styles in them that expect galleries to appear in a widget context, since previously galleries would have only appeared in post content. As noted in §Default Themes Updates for Media Widgets for Images, Video, and Audio:

Themes that add custom styles to the MediaElement.js player (namely Twenty Thirteen and Twenty Fourteen) were updated from just styling it within syndicated content, to also include instances within widgets. Most themes don’t restrict styles for captioned images or media players to just post content, that is, limit CSS selectors to classes output by post_class(). If your theme does, make sure to either remove that constraint or include a .widget selector.

In the same way for the Gallery widget, we need to make sure that all of the core themes are compatible. Gallery widgets need to be tested in all core themes and in each of their widget areas, while also changing settings like the number of columns and the image size, in order to check for the variations.

Once the core themes are updated then the changes will may be instructive for theme authors to make similar changes in their themes.

Attachments (11)

2017-a-gallery.jpg (258.9 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Seventeen
2016-a-gallery.jpg (238.5 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Sixteen
2015-a-gallery.jpg (193.7 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Fifteen
2014-a-gallery.jpg (179.7 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Fourteen
2013-a-gallery.jpg (333.1 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Thirteen
2012-a-gallery.jpg (206.8 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Twelve
2011-a-gallery.jpg (273.4 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Eleven (no sidebar)
2011-sidebar-gallery.jpg (102.0 KB) - added by joyously 3 weeks ago.
Gallery widgets in sidebar in Twenty Eleven
2010-a-gallery.jpg (252.2 KB) - added by joyously 3 weeks ago.
Gallery widgets in Twenty Ten
twentythirteen-gallery-widget-css-change-01.png (1.2 MB) - added by williampatton 5 days ago.
41969.2013-css-01.diff (732 bytes) - added by williampatton 5 days ago.

Change History (20)

#1 @westonruter
3 weeks ago

  • Keywords needs-patch added
  • Owner set to davidakennedy
  • Status changed from new to assigned

#2 @melchoyce
3 weeks ago

  • Keywords needs-screenshots ui-feedback added

Let's get some screenshots from each default theme, along with some style improvement suggestions :)

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 weeks ago

@joyously
3 weeks ago

Gallery widgets in Twenty Seventeen

@joyously
3 weeks ago

Gallery widgets in Twenty Sixteen

@joyously
3 weeks ago

Gallery widgets in Twenty Fifteen

@joyously
3 weeks ago

Gallery widgets in Twenty Fourteen

@joyously
3 weeks ago

Gallery widgets in Twenty Thirteen

@joyously
3 weeks ago

Gallery widgets in Twenty Twelve

@joyously
3 weeks ago

Gallery widgets in Twenty Eleven (no sidebar)

@joyously
3 weeks ago

Gallery widgets in sidebar in Twenty Eleven

@joyously
3 weeks ago

Gallery widgets in Twenty Ten

#4 @joyously
3 weeks ago

  • Keywords needs-screenshots removed

I added screenshots. They mostly look good, but Twenty Thirteen has some obvious problems, and Twenty Ten has a little overlap.

#5 @westonruter
6 days ago

  • Type changed from defect (bug) to task (blessed)

See similar task for media added to Text widget: #42203

This ticket was mentioned in Slack in #core-themes by westonruter. View the logs.


6 days ago

#7 @williampatton
5 days ago

A little bit of CSS can fix some of the issues shown in twentythirteen theme. It doesn't fix them all (larger amounts of columns with non-thumbnail image configs still have clearing issues) but it covers many of the cases.

I will continue to work towards fixing any unusual quirks in the styling of these widgets across core themes as I have time.

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


2 days ago

This ticket was mentioned in Slack in #core by davidakennedy. View the logs.


6 hours ago

Note: See TracTickets for help on using tickets.