#41988 closed enhancement (fixed)
Strict comparison for JavaScript type of check at line 110 in wp-admin/admin-footer.php
Reported by: | rnaby | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.8 | Priority: | low |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | 2nd-opinion |
Focuses: | javascript, coding-standards | Cc: |
Description
The typeof
checking for wpOnload
variable should use ===
comparison operator rather than ==
comparison operator. It'll make variable type checking strict.
Before or now the code is-
<script type="text/javascript">if(typeof wpOnload=='function')wpOnload();</script>
After applying the fix, the code is-
<script type="text/javascript">if(typeof wpOnload==='function')wpOnload();</script>
Attachments (1)
Change History (6)
#1
@
7 years ago
- Keywords 2nd-opinion added
- Priority changed from normal to low
- Version trunk deleted
Please note that there's #41057 to apply PHP coding standards in core once and for all. Perhaps we need a similar ticket for JS? That would be much easier than having dozens of very small tickets for things not really worth fixing on their own. In this particular section there's no bug caused by these comparisons anyway.
Note: See
TracTickets for help on using
tickets.
The diff patch file I generated by using RabbitVCS.