WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#42009 closed defect (bug) (fixed)

Fix tests for the wptextpattern TinyMCE plugin

Reported by: azaozz's profile azaozz Owned by: azaozz's profile azaozz
Milestone: 5.6 Priority: low
Severity: normal Version: 4.9
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

After the last TinyMCE update #40956 the tests for the wptextpattern plugin started failing only when run in PhantomJS. They still run properly in the browsers.

Change History (12)

#1 @azaozz
7 years ago

Seems editor.selection.getRng( true ) fails when used in mceType(). Don't see the cause. Going to temporarily disable these tests when run in PhantomJS until this is fixed.

#2 @azaozz
7 years ago

In 41620:

TinyMCE: disable the tests for wptextpatterns plugin in PhantomJS.

See #42009

This ticket was mentioned in ​Slack in #core by melchoyce. ​View the logs.
7 years ago

#4 @melchoyce
7 years ago

  • Milestone changed from 4.9 to 4.9.1

#5 @johnbillion
7 years ago

  • Keywords needs-patch added
  • Milestone changed from 4.9.1 to 5.0
  • Priority changed from normal to low

#6 @jorbin
6 years ago

  • Milestone changed from 5.0 to 5.1

#7 @pento
6 years ago

  • Milestone changed from 5.1 to Future Release

This ticket was mentioned in ​PR #716 on ​WordPress/wordpress-develop by ​desrosj.
4 years ago #8

  • Keywords has-patch has-unit-tests added; needs-patch removed

Reverting https://core.trac.wordpress.org/changeset/41620.

Trac ticket: https://core.trac.wordpress.org/ticket/42009.

#9 follow-up: @desrosj
4 years ago

  • Keywords needs-patch added; has-patch has-unit-tests removed

@azaozz It seems that this has been fixed upstream as reverting [41620] does not result in failing tests: ​https://github.com/WordPress/wordpress-develop/runs/1376143388?check_suite_focus=true

#10 in reply to: ↑ 9 @azaozz
4 years ago

Replying to desrosj:

It seems that this has been fixed upstream...

Yep, confirmed. No need to skip these tests now in PhantomJS.

Arguably the next conditional is not needed too as IE cannot be < 11 now, but can leave it just in case somebody tries to run the tests manually in old IE.

Last edited 4 years ago by azaozz (previous) (diff)

#11 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 49556:

Tests QUnit: Remove restriction on running the TinyMCE Textpattern WP plugin tests in PhantomJS.

Props @desrosj.
Fixes #42009.

#12 @SergeyBiryukov
4 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 5.6
Note: See TracTickets for help on using tickets.