WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #42022


Ignore:
Timestamp:
09/28/2017 07:35:26 PM (19 months ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42022

    • Property Status changed from new to accepted
    • Property Summary changed from Customizer: Change "day" to "date" in scheduling to Customize: Fix date time control label
    • Property Keywords good-first-bug removed
    • Property Owner set to westonruter
    • Property Type changed from enhancement to defect (bug)
  • Ticket #42022 – Description

    v2 v3  
    1 See attached image.
     1See attached image. “Day” should be replaced with “Date”.
    22
    33Located in "Customize" —> click the cog next to "Publish" —> click "Schedule"
     4
     5* The control should be able to be re-used for multiple settings (currently it can't).
     6* Changes to the setting should sync into the control.
     7* The `defaultValue` param should be replaced with using the value that is provided to the setting when instantiating (see #37964).
     8* The time portion the control should be able to be optional.
     9* The `maxlength` is not appropriate for `number` inputs.
     10* “form elements label are not explicitly associated with for/id attributes as required by the accessibility standard for any new code in core.” ([https://wordpress.slack.com/archives/C0381N237/p1506612587000161 via] @afercia)
     11* “the preview link contains a few error that are easily catchable just validating the HTML, most notably: a label element can contain just one labelable element” ([https://wordpress.slack.com/archives/C0381N237/p1506612775000090 via] @afercia)
     12* “In the template, there are a couple inputs with attributes with a double quote at the end” ([https://wordpress.slack.com/archives/C0381N237/p1506613180000846 via] @afercia)