WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#42022 closed defect (bug)

Customize: Fix date time control label — at Version 3

Reported by: melchoyce Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description (last modified by westonruter)

See attached image. “Day” should be replaced with “Date”.

Located in "Customize" —> click the cog next to "Publish" —> click "Schedule"

  • The control should be able to be re-used for multiple settings (currently it can't).
  • Changes to the setting should sync into the control.
  • The defaultValue param should be replaced with using the value that is provided to the setting when instantiating (see #37964).
  • The time portion the control should be able to be optional.
  • The maxlength is not appropriate for number inputs.
  • “form elements label are not explicitly associated with for/id attributes as required by the accessibility standard for any new code in core.” (via @afercia)
  • “the preview link contains a few error that are easily catchable just validating the HTML, most notably: a label element can contain just one labelable element” (via @afercia)
  • “In the template, there are a couple inputs with attributes with a double quote at the end” (via @afercia)

Change History (4)

#1 @melchoyce
2 years ago

  • Description modified (diff)

#2 @melchoyce
2 years ago

  • Description modified (diff)

#3 @westonruter
2 years ago

  • Description modified (diff)
  • Keywords good-first-bug removed
  • Owner set to westonruter
  • Status changed from new to accepted
  • Summary changed from Customizer: Change "day" to "date" in scheduling to Customize: Fix date time control label
  • Type changed from enhancement to defect (bug)
Note: See TracTickets for help on using tickets.