WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#42048 closed defect (bug) (fixed)

Customize Themes: correctly hide all publish buttons when themes panel is open

Reported by: celloexpressions Owned by:
Milestone: 4.9 Priority: normal
Severity: normal Version: trunk
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

The publish settings button is showing up still when the themes panel is opened. Nothing can be published/scheduled/etc. when the themes panel is opened, so we need to nsure these buttons are hidden.

Attachments (1)

42048.diff (1.4 KB) - added by celloexpressions 3 weeks ago.
Replace .save with #customize-save-button-wrapper to capture all buttons here.

Download all attachments as: .zip

Change History (4)

@celloexpressions
3 weeks ago

Replace .save with #customize-save-button-wrapper to capture all buttons here.

#1 @westonruter
3 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

This was actually just fixed as of [41667]. Not only is the button when the panel is expanded, but the buttons animate up and down together: https://youtu.be/yU_yaj2_RRk

#2 @melchoyce
3 weeks ago

Just want to clarify, why can't folks publish when the theme browser is open?

#3 @westonruter
3 weeks ago

@melchoyce I think it's because they haven't selected a theme to activate. There's nothing to Publish when you're in the Themes panel. It's like an interstitial.

Note: See TracTickets for help on using tickets.