WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#42056 closed enhancement (fixed)

Twenty Seventeen: role="complementary" are missing labels

Reported by: sami.keijonen Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.8.2
Component: Bundled Theme Keywords:
Focuses: accessibility Cc:

Description

From the quidelines:

If a particular role appears more than once on a page, you should provide an ARIA label for that role

We do this already for <navigation> but not for <aside>. Just like navigation there can be several <aside role="complementary"> in the theme and we should provide labels for them. Otherwise screen readers would announce 2 "complementary" regions without knowing the separation of them

https://cloudup.com/cOjsuxTbf1E

https://cldup.com/Gj_CY0Dl81-1200x1200.png

I propose that we add labels to <aside> with the same as widget names:

  1. Blog Sidebar
  2. Footer 1
  3. Footer 2

Attachments (1)

42056.patch (1.2 KB) - added by sami.keijonen 3 months ago.

Download all attachments as: .zip

Change History (7)

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


3 months ago

#2 @sami.keijonen
3 months ago

Added a patch and finding good wording is super hard in this case because you don't know what kind of widgets there will be.

For now I added

  1. Blog Sidebar
  2. Footer

Here is screenshot after the patch.

https://cldup.com/IMTnzeTICL.png

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 months ago

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


3 months ago

#5 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 4.9

#6 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41687:

Twenty Seventeen: Add missing labels for <aside role="complementary"> widget areas.

Props sami.keijonen.
Fixes #42056.

Note: See TracTickets for help on using tickets.