WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42066, comment 12


Ignore:
Timestamp:
06/19/2022 08:43:20 AM (3 years ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #42066, comment 12

    initial v1  
    1515@afercia @peterwilsoncc @audrasjb Let me know your thoughts on this method, and whether it should also cover the markup for `class="current" aria-current="page"` and instead change the `"current"` key to `bool` type.
    1616
    17 Should a general function be preferred to cover link markup generation in most cases, I drafted [https://github.com/WordPress/wordpress-develop/pull/2380 PR 2380] for this, which also supports additional attributes (including boolean attributes) and which is easily applied to this use case.
     17Should a general function be preferred to cover link markup generation in most cases, I drafted [https://github.com/WordPress/wordpress-develop/pull/2380 PR 2380] with `wp_create_links()` for this, which also supports additional attributes (including boolean attributes) and which is easily applied to this use case.