WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#42070 closed enhancement (fixed)

Remove networks_have_paths cache key

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.0 Priority: normal
Severity: normal Version: 4.6
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite Cc:

Description

The cache key networks_have_paths is used in bootstrap process to load networks. It caches values stored in from a WP_Network_Query query. WP_Network_Query already has caching, make this cache pointless.

Change History (10)

#1 @spacedmonkey
3 years ago

  • Milestone changed from Awaiting Review to 6.0
  • Owner set to spacedmonkey
  • Status changed from new to assigned
  • Version set to 4.6

This ticket was mentioned in ​PR #2504 on ​WordPress/wordpress-develop by ​uday-kokitkar.
3 years ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/42070

This ticket was mentioned in ​Slack in #core-multisite by spacedmonkey. ​View the logs.
3 years ago

#5 @spacedmonkey
3 years ago

The PR at ​#2504 looks good to go. I think this should be committed and be part of 6.0.

#6 @johnbillion
3 years ago

  • Keywords commit added

#7 @johnjamesjacoby
3 years ago

PR looks good to me.

​JJJ commented on ​PR #2504:
3 years ago #8

The only reservation I can dream up with removing this, is the potential for breakage for sites manually setting this cache key inside of a custom sunrise.php.

The only reason they would do that is specifically to get ahead of and around this query.

#9 @peterwilsoncc
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53083:

Networks and Sites: Remove duplicate cache entry.

Remove the networks_have_paths, site-options cache entry as it duplicates caching within the WP_Network_Query class.

Props uday17035, spacedmonkey, johnbillion, johnjamesjacoby.
Fixes #42070.

Note: See TracTickets for help on using tickets.