WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42072, comment 3


Ignore:
Timestamp:
10/03/2017 03:40:53 PM (4 years ago)
Author:
flixos90
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42072, comment 3

    initial v1  
    11We should consider simplifying the function further, by internally using the new `get_site_by()`. See https://core.trac.wordpress.org/ticket/40180#comment:24
    22
    3 * The advantage would be less code to maintain, and we could theoretically even deprecate this function at some point (not a necessity though).
     3* The advantage would be less code to maintain.
    44* The disadvantage would be that `get_site_by()` returns a full object, while we only need an ID here. Not sure that's a real issue though, since it only queries for one result anyway, so it shouldn't have a significant impact on performance.