WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#42090 closed task (blessed) (fixed)

Bundled Themes: Bump version numbers and update changelogs for 4.9 release

Reported by: davidakennedy Owned by: davidakennedy
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

For submission to WP.org directory to coordinate with 4.9 release, let's bump the version numbers for themes and update the changelogs. Most default themes received some work this release.

Tickets for this in the past:

4.5: #36354
4.6: #37426
4.7: #38858
4.8: #40905

Handbook page: https://make.wordpress.org/core/handbook/about/release-cycle/update-bundled-themes/

Anyone is welcome to help with this, but I'll assign myself as I usually test the themes prior to release and see this through. Any and all help is welcome! :)

Attachments (11)

42090.patch (14.8 KB) - added by lemacarl 7 weeks ago.
42090.1.diff (2.2 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyTen v2.4 - Update Changelog
42090.2.diff (4.9 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyElevan v2.7 - Update Changelog
42090.3.diff (7.1 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyTwelve v2.4 - Update Changelog
42090.4.diff (9.1 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyThirteen v2.3 - Update Changelog
42090.5.diff (11.4 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyFourteen v2.1 - Update Changelog
42090.6.diff (13.6 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentyFifteen v1.9 - Update Changelog
42090.7.diff (15.9 KB) - added by maedahbatool 7 weeks ago.
NEW: TwentySixteen v1.4 - Update Changelog
42090.8.diff (17.9 KB) - added by mrahmadawais 7 weeks ago.
NEW: TwentySeventeen v1.4 - Update Changelog
42090.9.patch (18.8 KB) - added by davidakennedy 7 weeks ago.
Added additional updates copyright dates in a few spots.
42090.10.patch (38.4 KB) - added by davidakennedy 7 weeks ago.
Updated patch with new POT files for Twenty Ten and Eleven.

Download all attachments as: .zip

Change History (35)

#1 @davidakennedy
2 months ago

  • Owner set to davidakennedy
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by westonruter. View the logs.


2 months ago

#3 @westonruter
2 months ago

  • Type changed from defect (bug) to task (blessed)

#4 @lemacarl
2 months ago

@davidakennedy I'm interested in working on this ticket but I would like to know how do I read a theme's changelog on Trac and know the latest tested-upto version?

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 weeks ago

#6 @davidakennedy
8 weeks ago

Hi @lemacarl – thanks for being willing to jump in.

You can find instructions on this page in the core handbook: https://make.wordpress.org/core/handbook/about/release-cycle/update-bundled-themes/

Example changelog: https://core.trac.wordpress.org/log/trunk/src/wp-content/themes/twentyseventeen/

So the changes we'd want to highlight are from the last time a theme was released. In this case, the last major release for Twenty Seventeen was WordPress 4.8. You can see that in the commit message, "Bundled Themes - Bump themes in preparation for 4.8 Change version …"

Let me know if you have questions, or find something confusing on that handbook page, so I can update it.

#7 @davidakennedy
8 weeks ago

Also worth noting, I'll be diving into this once Beta 4 hits.

#8 @lemacarl
8 weeks ago

@davidakennedy Thanks for this. Very helpful

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 weeks ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 weeks ago

#11 @davidakennedy
7 weeks ago

Here are the changelogs for this release. I should have the patch up in the next day or two.

Changelogs

Seventeen

Version 1.4

Released: November 14, 2017

  • Remove/merge unused variables in content-front-page.php. (#39771)
  • Correct the <code>@return</code> value for <code>twentyseventeen_post_thumbnail_sizes_attr()</code>. (#41830)
  • Document the type of <code>$item</code> argument in <code>twentyseventeen_dropdown_icon_to_menu_link()</code> more accurately. (#41923)
  • Add Periscope icon to supported social links. (#40959)
  • Add Docker Hub icon to supported social links. (#41529)
  • Add missing labels for <code><aside role="complementary"></code> widget areas. (#42056)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40184), (#40138)
  • Add missing <code>@return</code> tag for <code>twentyseventeen_video_controls()</code>. (#41927)
  • Fix positioning of edit shortcuts when partials are nested inside a frontpage panel. (#41557)
  • Fix double bottom-margins below embeds. (#42118)
  • Make gallery link styles consistent in all widget areas. (#42302), (#41969)

Sixteen

Version 1.4

Released: November 14, 2017

  • Allow category display in post preview even when there is only one category. (#39531)
  • Replace a variety of http links referenced in inline docs with their <code>https</code> counterparts. (#40732)
  • Correct the <code>@return</code> value for <code>twentysixteen_post_thumbnail_sizes_attr()</code>. (#41830)
  • Replace inline control structureв to improve code readability. (#38468)
  • Make sure comment number comparison in comments.php works as expected. (#39660)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)

Fifteen

Version 1.9

Released: November 14, 2017

  • Remove "called called" dittography typo. (#41836), (#41841)
  • Add missing comma in <code>ie.css</code>. (#41890)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Add missing singular placeholder in comments.php. (#39660)

Fourteen

Version 2.1

Released: November 14, 2017

  • Upgrade MediaElement.js from 2.22.0 to 4.2.3. (#39686)
  • Remove "called called" and "can can" dittography. (#41836)
  • Upgrade MediaElement.js from 2.22.0 to 4.2.3. (#39686)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Add missing singular placeholder in comments.php. (#39660)
  • Make sure new gallery widgets look good in themes. (#41969)

Thirteen

Version 2.3

Released: November 14, 2017

  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Make sure new gallery widgets look good in themes. (#41969)

Twelve

Version 2.4

Released: November 14, 2017

  • Remove "called called" and "can can" dittography. (#41836)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Make sure new gallery widgets look good in themes. (#41969)

Eleven

Version 2.7

Released: November 14, 2017

  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Make sure new gallery widgets look good in themes. (#41969)

Ten

Version 2.4

Released: November 14, 2017

  • Remove "called called" and "can can" dittography. (#41836)
  • Change tag cloud format to a list (<ul>) for better semantics and accessibility. (#40138)
  • Make sure new gallery widgets look good in themes. (#41969)

@lemacarl
7 weeks ago

#12 @lemacarl
7 weeks ago

  • Keywords has-patch added; needs-patch removed

@davidakennedy Thanks for the change log. I really didn't know how to begin with it and I didn't want to ask too many newbie questions but I think next time if need be I could now compile one. I used the final patch from #40905 as a template. Also interested in creating the codex pages but don't know how to

#13 @maedahbatool
7 weeks ago

I am taking on this ticket and improving everything like I did in the last release. Will be submitting patches for every theme going all in one by one.

@maedahbatool
7 weeks ago

NEW: TwentyTen v2.4 - Update Changelog

#14 @mrahmadawais
7 weeks ago

@maedahbatool Great, I am half way there on TwentySeventeen so leave that for me :)

@maedahbatool
7 weeks ago

NEW: TwentyElevan v2.7 - Update Changelog

@maedahbatool
7 weeks ago

NEW: TwentyTwelve v2.4 - Update Changelog

@maedahbatool
7 weeks ago

NEW: TwentyThirteen v2.3 - Update Changelog

@maedahbatool
7 weeks ago

NEW: TwentyFourteen v2.1 - Update Changelog

@maedahbatool
7 weeks ago

NEW: TwentyFifteen v1.9 - Update Changelog

@maedahbatool
7 weeks ago

NEW: TwentySixteen v1.4 - Update Changelog

@mrahmadawais
7 weeks ago

NEW: TwentySeventeen v1.4 - Update Changelog

#15 @mrahmadawais
7 weeks ago

@davidakennedy Take a look, @maedahbatool and I have added all the changelogs and edited the files + added the patches to this ticket for the core. It looks good and just take a look at it.

@davidakennedy
7 weeks ago

Added additional updates copyright dates in a few spots.

#16 @davidakennedy
7 weeks ago

@lemacarl @mrahmadawais @maedahbatool Thank you all for your work here! It's much appreciated.

You all have the right idea. :) It's best to combine these all into one patch as I think @mrahmadawais did. Worth noting too that I went through in my patch and updated a few copyright dates where needed.

This should be good to go, and I'll get it committed soon.

I also tested all these themes back a few versions to 4.4 to make sure there were no regressions. Everything looks solid.

Lastly, we'll need to update the POT files for Twenty Ten and Eleven on or prior to release day. cc: @westonruter

#17 @davidakennedy
7 weeks ago

  • Keywords commit added

#18 @davidakennedy
7 weeks ago

Just wanted to also say changelogs on the Codex have been updated. Thanks all!

#19 @mrahmadawais
7 weeks ago

@davidakennedy

Worth noting too that I went through in my patch and updated a few copyright dates where needed.

I thought all of the copyright notices would already be right as in the last release was also this year. But I stand corrected.

This ticket was mentioned in Slack in #core by davidakennedy. View the logs.


7 weeks ago

@davidakennedy
7 weeks ago

Updated patch with new POT files for Twenty Ten and Eleven.

This ticket was mentioned in Slack in #core-committers by davidakennedy. View the logs.


7 weeks ago

#22 @obenland
7 weeks ago

  • Keywords dev-reviewed added

#23 @davidakennedy
7 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42105:

Bundled Themes: Bump version numbers and update changelogs for 4.9 release

  • Also, updates POT files for Twenty Ten and Twenty Eleven.

Props lemacarl, maedahbatool, mrahmadawais, davidakennedy.

Fixes #42090.

#24 @westonruter
7 weeks ago

In 42106:

Bundled Themes: Fix fragile update-theme phpunit test which broke after version updates in [42105].

See #42090.

Note: See TracTickets for help on using tickets.