WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#42097 closed task (blessed) (fixed)

Update $_old_files for 4.9

Reported by: ocean90 Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:
PR Number:

Description

$ svn diff --summarize https://core.svn.wordpress.org/tags/4.8.2 https://core.svn.wordpress.org/trunk | grep '^D'
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/froogaloop.min.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/flashmediaelement.swf
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/bigplay.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/skipback.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/loading.gif
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/jumpforward.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/bigplay.svg
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/controls.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/silverlightmediaelement.xap
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/controls.svg
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/background.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/plugins/swfupload.queue.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/plugins/swfupload.swfobject.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/plugins/swfupload.cookies.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/plugins/swfupload.speed.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/plugins
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/swfupload/swfupload.swf
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/plupload/plupload.full.min.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/plupload/plupload.silverlight.xap
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/plupload/plupload.flash.swf
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/includes/class-wp-press-this.php
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-rtl.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-rtl.min.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-editor-rtl.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-editor-rtl.min.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this.min.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-editor.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/css/press-this-editor.min.css
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/js/press-this.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/js/bookmarklet.min.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/js/press-this.min.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-admin/js/bookmarklet.js

Looks like the MediaElement files are missing.

Attachments (1)

42097.diff (2.0 KB) - added by westonruter 2 years ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#3 in reply to: ↑ description @netweb
2 years ago

Replying to ocean90:

Looks like the MediaElement files are missing.

D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/background.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/bigplay.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/bigplay.svg
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/controls.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/controls.svg
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/flashmediaelement.swf
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/froogaloop.min.js
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/jumpforward.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/loading.gif
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/skipback.png
D       https://core.svn.wordpress.org/tags/4.8.2/wp-includes/js/mediaelement/silverlightmediaelement.xap

All 11 mediaelement files were removed in [41198] as part of the MediaElement.js upgrade from 2.22.0 to 4.2.3

#4 @westonruter
2 years ago

  • Owner set to westonruter
  • Status changed from new to accepted

#5 @westonruter
2 years ago

svn diff --summarize https://core.svn.wordpress.org/tags/4.8.2 https://core.svn.wordpress.org/trunk | grep '^D' | cut -c9- | sed "s:^.*/tags/[^/]*/:':" | sed "s:$:',:" | sort

'wp-admin/css/press-this-editor-rtl.css',
'wp-admin/css/press-this-editor-rtl.min.css',
'wp-admin/css/press-this-editor.css',
'wp-admin/css/press-this-editor.min.css',
'wp-admin/css/press-this-rtl.css',
'wp-admin/css/press-this-rtl.min.css',
'wp-admin/css/press-this.css',
'wp-admin/css/press-this.min.css',
'wp-admin/includes/class-wp-press-this.php',
'wp-admin/js/bookmarklet.js',
'wp-admin/js/bookmarklet.min.js',
'wp-admin/js/press-this.js',
'wp-admin/js/press-this.min.js',
'wp-includes/js/mediaelement/background.png',
'wp-includes/js/mediaelement/bigplay.png',
'wp-includes/js/mediaelement/bigplay.svg',
'wp-includes/js/mediaelement/controls.png',
'wp-includes/js/mediaelement/controls.svg',
'wp-includes/js/mediaelement/flashmediaelement.swf',
'wp-includes/js/mediaelement/froogaloop.min.js',
'wp-includes/js/mediaelement/jumpforward.png',
'wp-includes/js/mediaelement/loading.gif',
'wp-includes/js/mediaelement/silverlightmediaelement.xap',
'wp-includes/js/mediaelement/skipback.png',
'wp-includes/js/plupload/plupload.flash.swf',
'wp-includes/js/plupload/plupload.full.min.js',
'wp-includes/js/plupload/plupload.silverlight.xap',
'wp-includes/js/swfupload/plugins',
'wp-includes/js/swfupload/plugins/swfupload.cookies.js',
'wp-includes/js/swfupload/plugins/swfupload.queue.js',
'wp-includes/js/swfupload/plugins/swfupload.speed.js',
'wp-includes/js/swfupload/plugins/swfupload.swfobject.js',
'wp-includes/js/swfupload/swfupload.swf',

(Minus the files in the plugins directory which itself is being deleted.)

@westonruter
2 years ago

#6 @westonruter
2 years ago

  • Keywords has-patch added; needs-patch removed

#7 @westonruter
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 42015:

Update $_old_files to add the deleted MediaElement.js files when it was upgraded from 2.22.0 to 4.2.3.

Amends [41198].
See #39686.
Fixes #42097.

This ticket was mentioned in Slack in #core by westonruter. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.