Customize Menus: Adjust "Menu Locations" labels for singular/plural

[melchoyce]

Currently, "Menu Locations" is plural even if you only have one location to assign menus to.

[felipeelia]

I talked about this with @bpayton at slack and I've uploaded a patch (trying) to help. Note that it also changes View All Locations to View Location when there is only one of them.

[melchoyce]

Looks good to me!

[westonruter]

It looks good to me too, but @felipeelia why introduce a new template variable for locationsTitle when it could just replace the _e() call with an echo _n() in tmpl-nav-menu-locations-header?

[felipeelia]

Replying to westonruter:

It looks good to me too, but @felipeelia why introduce a new template variable for locationsTitle when it could just replace the _e() call with an echo _n() in tmpl-nav-menu-locations-header?

Hi @westonruter :)
I think it couldn't be replaced by _n directly because we don't have the number of locations avaiable inside print_templates() function. Please correct me if I'm wrong.

[bpayton]

I was happy to see the new variable because I was planning to introduce it anyway to share it with class-wp-customize-nav-menu-locations-control.php.

[bpayton]

We need to fix that title as well, but I can fix that as part of #42113.

[westonruter]

Replying to felipeelia:

I think it couldn't be replaced by _n directly because we don't have the number of locations avaiable inside print_templates() function. Please correct me if I'm wrong.

The printing of templates would happen even after enqueue_scripts, so the number of registered nav menus would for sure be known at that point. But since @bpayton would like to re-use the string, the patch is good as is.

[westonruter]

In 41812:

Customize: Adjust "Menu Locations" labels for singular/plural.

Props felipeelia.
Fixes #42112.

[westonruter]

In 41816:

Customize: Fix string translations for singular vs plural after [41812].

Props felipeelia, tobifjellner, SergeyBiryukov.
See #42112.
Fixes #42170.