Customize Menus: Copy updates

[melchoyce]

We need to update the New Menu —> Menu Locations description to speak better to new menus.

[bpayton]

The attached mock is larger than I intended, but it's fine for reference.

@melchoyce What do you want "widget" to link to?
Maybe ​https://codex.wordpress.org/WordPress_Widgets ?

[melchoyce]

Replying to bpayton:

@melchoyce What do you want "widget" to link to?
Maybe ​https://codex.wordpress.org/WordPress_Widgets ?

Yup! (Sadly, there's no Codex entry on the menu widget itself.)

[westonruter]

Should the widget link should perhaps link to the Widgets panel in the Customizer?

[melchoyce]

Depends — not sure knocking them out of the menu creation flow is the right thing here, especially since even if they do want to use a menu widget, they need to make the menu first.

[bpayton]

That was my read on it as well. We link to the Widget panel in Menus -> View All Locations, but when creating a menu, I would be looking for additional info on widgets and surprised to be taken to another panel.

[bpayton]

Hi @westonruter, I have a patch for this. This is a simpler task, but I'm uncertain whether I handled the combination of i18n and HTML correctly. Are you up for taking a look?

​https://github.com/brandonpayton/wordpress-develop/pull/2

[westonruter]

PR approved. Ready for design review and commit.

[melchoyce]

Two things:

• Can we put "(If you plan to use a menu widget, skip this step.)" onto a new line?
• I know this isn't a new thing, but the spacing those menu location list items is very high, thanks to the margin-bottom: 12px; on .customize-control. Do you know where that was introduced? The 6px it falls back to is what seems to be used on all the other radio/checkbox lists.

[bpayton]

I pushed an update to put the menu widget note on a new line.

I took a look at the spacing of the location list items and confirmed the issue only affects the new-menu section. The spacing of the checkboxes in edit-menu sections looks just fine (though I did push a commit to add padding between locations and the auto-add-top-level-pages control).

The strange thing is that the edit menu section relies on styles defined in nav-menus.css and a rule for .menu li. The rule(s) apply because we're manually adding the menu class to the content container when a menu section is expanded. This is poor because we're relying on styles defined for menu admin rather than for Customizer. To address the new-menu spacing issue and to reduce the edit-menu reliance on nav-menus.css, I added (and pushed) a rule that explicitly sets item spacing for the new- and edit-menu sections.

@melchoyce, this is ready for another review.

[melchoyce]

Thanks @bpayton. Can you add a screenshot?

[bpayton]

Edit Menu: Margin is improved for Menu Options

[bpayton]

@melchoyce I added a before and after shot for menu create and edit. The left is before, and the right is after.

[melchoyce]

Looks good, let's ship it 👍

[westonruter]

In 41832:

Customize: Vary description for nav menu locations control based on whether it is shown during menu creation.

Also fix issue with initial visibility of notice when there are no menus.

Amends [41823].
Props bpayton, melchoyce, westonruter.
See #42116.
Fixes #42113.