Opened 8 years ago
Closed 8 years ago
#42118 closed defect (bug) (fixed)
Twenty Seventeen: Double bottom-margins appear below embeds
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.9 | Priority: | normal |
| Severity: | normal | Version: | 4.7 |
| Component: | Bundled Theme | Keywords: | has-patch |
| Focuses: | Cc: |
Description
There is some CSS in Twenty Seventeen to make sure embeds and iframes fit their containers:
embed, iframe, object { margin-bottom: 1.5em; max-width: 100%; }
However, in the case of an oEmbed where a video appears inside of its own paragraph the result is a double margin between the iframe and the next paragraph. The margin should only be added if the iframe is the only child of the parent element.
This is a problem both for videos in post content and for videos embedded into the Text widget via #40854.
Attachments (2)
Change History (6)
Note: See
TracTickets for help on using
tickets.
Tested this. I can confirm the bug, and the patch looks good to me. Thanks @westonruter!