WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#42123 closed defect (bug) (fixed)

Customize Menus: Menu list arrows aren't vertically centered

Reported by: melchoyce Owned by: melchoyce
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: good-first-bug has-patch needs-testing
Focuses: ui Cc:

Description

See attached screenshot of how it is now, and an image how it should be.

Attachments (4)

menu-arrow-alignment.png (30.4 KB) - added by melchoyce 4 years ago.
42123.patch (426 bytes) - added by dualcube_subrata 4 years ago.
Menu list arrows are vertically centered new
top.png (3.0 MB) - added by melchoyce 4 years ago.
centered.png (3.0 MB) - added by melchoyce 4 years ago.

Change History (11)

@dualcube_subrata
4 years ago

Menu list arrows are vertically centered new

#1 @dualcube_subrata
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#2 @celloexpressions
4 years ago

  • Version changed from trunk to 4.3

Note that this is not specific to menus. All customize section arrows are currently top-aligned, not centered, since this design was introduced in 4.3.

Does top or center-aligning work better visually when a majority of section titles are only a single line and only a few are taller? We should document screenshots of those situations with this change.

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


4 years ago

#4 @afercia
4 years ago

Also, what if the translation or the menu name are so long that there are actually 3 lines of text?

@melchoyce
4 years ago

@melchoyce
4 years ago

#5 @melchoyce
4 years ago

Between top.png and centered.png, I definitely prefer the center alignment for the arrow.

#6 @Dualcube
4 years ago

In terms of look and feel I am with @melchoyce, as otherwise it looks odd when we have both single line and multiple lines menu items.

#7 @melchoyce
4 years ago

  • Owner set to melchoyce
  • Resolution set to fixed
  • Status changed from new to closed

In 41808:

Customizer: Vertically center section arrows.

Props dualcube_subrata.
Fixes #42123.

Note: See TracTickets for help on using tickets.