Changes between Version 1 and Version 2 of Ticket #42124, comment 2
- Timestamp:
- 10/06/2017 06:22:27 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #42124, comment 2
v1 v2 1 1 This patch seems right. 2 2 3 ` assertNotInternalType()` claims to accept a PHP Resource variable type, so the `resource` string would not be sufficient; it would need to be an actual resource type variable. If this was working before PHPUnit 6.4.0, it probably should not have been.3 `get_resource_type()` accepts a PHP Resource variable type, so the `resource` string would not be sufficient in `assertNotInternalType()`; it would need to be an actual resource type variable. If this was working before PHPUnit 6.4.0, it probably should not have been. 4 4 5 5 WordPress uses Resource variables in quite a few places (where server & database connections are used) but also generally shields us from needing to do very much with them until we hit API bedrock. @joemcgill you're probably familiar with them with your recent trip down MimeType boulevard.