#42126 closed defect (bug) (fixed)
Customize: Fix confusion related to visibility of Themes panel and drafted/scheduled changesets
Reported by: | westonruter | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | has-patch |
Focuses: | Cc: |
Description
With the addition of drafting and scheduling of changesets in #39896, we do not allow for theme switching to be done when a changeset has been saved as a draft or scheduled. There are a few technical reasons for this:
- Changesets cannot be scheduled with a theme switch. This is because when a changeset post gets published during WP Cron, the new theme is not active and so none of the theme-specific settings will be loaded.
- Publish settings section not available for theme preview because non-authoritative users cannot preview theme switch, so presenting the “preview link” control could result in users not being able to access it.
- The previewed theme is not stored in the changeset, and so when returning to the Customizer later the theme being previewed at the time of saving would not then be restored. See #39031.
There may be future ways around these issues, but for 4.9 the scope is to just disable theme switching when you have drafted or scheduled changes.
However, there are currently two issues with the current implementation:
- As soon as you switch the status to draft or scheduled, the Themes panel disappears without warning. Users will not know where it went and why. There needs to be a notification explaining why they cannot switch themes. See conversation at https://wordpress.slack.com/archives/C0381N237/p1506983729000264
- If you have drafted or scheduled a changeset, if you go to the Themes admin screen and click Live Preview for a different theme, the Customizer is currently allowing the theme preview even though it has autoloaded the pending changeset. This results in the themes panel being hidden even though the button says "Activate & Publish". This is wrong, and when the Customizer is loaded with a non-active theme then we need to prevent establishing an existing changeset (and so a new changeset would be created as in branching mode). Reported here: https://wordpress.org/support/topic/unable-to-see-new-theme-browsing-experience-in-customizer/
Attachments (1)
Change History (10)
#2
@
7 years ago
- Keywords has-patch added
- Owner set to melchoyce
- Status changed from new to reviewing
PR with changes: https://github.com/xwp/wordpress-develop/pull/277
#3
@
7 years ago
- Owner changed from melchoyce to westonruter
- Status changed from reviewing to accepted
I just found that that the changes didn't account for the theme installation flow. I need to fix that.
Mockup: theme-browser-scheduled-warning-flow.jpg