WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#42129 closed defect (bug) (fixed)

Code Editor: warning icon issues

Reported by: joyously Owned by: obenland
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: General Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

  • The icon shown when there is a CodeMirror Warning on the content has the same mouse cursor as a link or button, but is neither. Would it be better to use a help cursor?
  • Is there another way besides hover to see the warnings? Users on touch devices won't be able to see them.
  • When there are multiple warnings on one line (such as a minified CSS file), hovering over the icon does not show the warnings. You have to hover just below the icon instead.

Attachments (2)

code-editor-cursor.gif (627.5 KB) - added by joyously 2 years ago.
42129.diff (498 bytes) - added by obenland 2 years ago.

Download all attachments as: .zip

Change History (7)

#1 @melchoyce
2 years ago

  • Milestone changed from Awaiting Review to 4.9

@obenland
2 years ago

#2 @obenland
2 years ago

  • Keywords has-patch needs-testing added
  • Owner set to obenland
  • Status changed from new to accepted

42129.diff should fix item #1 and #3. @joyously would you mind double-checking?

On mobile, tapping the icon should show the message, tapping the gutter hide it.

This ticket was mentioned in Slack in #core-customize by obenland. View the logs.


2 years ago

#4 @melchoyce
2 years ago

42129.diff looks good to me 👍

#5 @melchoyce
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41830:

Code Editors: Improve cursor interactions on warning notices.

Fixes an issue where hovering over the warning icon didn't work if there were multiple warnings on the same line of code. Also updates the cursor from "pointer" to "help" when hovering over warnings and errors.

Props joyously, obenland.
Fixes #42129.

Note: See TracTickets for help on using tickets.