WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 18 months ago

Last modified 18 months ago

#42149 closed defect (bug) (worksforme)

Missing numbered placeholders in options-general. and deprecated.php

Reported by: birgire Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:
PR Number:

Description

After reading #42142 on missing numbererd placeholders in wp-db.php, I checked if there were others.

There are cases in options-general.php

'The %s constant in your %s file is no longer needed.'

and in deprecated.php:

'Displaying %s–%s of %s'

Attachments (1)

42149.diff (2.2 KB) - added by birgire 2 years ago.

Download all attachments as: .zip

Change History (4)

@birgire
2 years ago

#1 @birgire
2 years ago

  • Keywords has-patch added

In 42149.diff

  • Ordered the multiple placeholders
  • Added comments for translators, according to #38882

#2 @johnbillion
18 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Thanks for the patch, @birgire , but I'm going to close this because:

  1. The do_paging() function is deprecated and we don't want to burden translators with an unnecessary change to a string in a deprecated function.
  2. The numbered placeholders in options-general.php were fixed in [42343].

#3 @birgire
18 months ago

Thanks for the update @johnbillion, good point regarding deprecated functions.

Note: See TracTickets for help on using tickets.