Make WordPress Core

Opened 4 years ago

Last modified 6 weeks ago

#42156 reviewing enhancement

Adjust the inline docs for get_sites() to avoid WP_Site_Query doc-duplication

Reported by: birgire Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version: 4.6
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: docs, multisite Cc:


The get_sites() is a wrapper for a WP_Site_Query object, so to avoid doc duplication, we should adjust the inline docs for that function.

Similar to what has been done for the documentation of the get_posts() function, that's a wrapper for a WP_Query object.

Code reference:







Related #42117

Attachments (2)

42156.diff (4.7 KB) - added by felipeelia 4 years ago.
42156.2.diff (4.7 KB) - added by felipeelia 4 years ago.

Download all attachments as: .zip

Change History (10)

#1 @birgire
4 years ago

I think this would be a good-first-bug, but I can't mark it as such.

#2 @johnbillion
4 years ago

  • Keywords needs-patch good-first-bug added

4 years ago

#3 @felipeelia
4 years ago

  • Keywords has-patch added; needs-patch removed

This is my first contribution, so please tell me if I'm doing something wrong :)

#4 @birgire
4 years ago

Thanks for the patch @felipeelia

That looks good to me - I'm just wondering if we should keep it in one line, instead of two.

Wasn't there any recommended maximum length of comments? It would be informative to check that.

4 years ago

#5 @felipeelia
4 years ago

Thanks @birgire!

I found a recommendation here. It can be 120 characters wide, maintaining it in one line we get just 108 (with indentation).

#6 @DrewAPicture
3 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

Hi @felipeelia, thanks for the patches! I'll review them and get back to you with any feedback I might have.

This ticket was mentioned in Slack in #core by sergey. View the logs.

6 weeks ago

#8 @SergeyBiryukov
6 weeks ago

  • Milestone changed from Awaiting Review to 5.8
  • Owner changed from DrewAPicture to SergeyBiryukov
Note: See TracTickets for help on using tickets.