Adjust the inline docs for get_sites() to avoid WP_Site_Query doc-duplication

[birgire]

The get_sites() is a wrapper for a WP_Site_Query object, so to avoid doc duplication, we should adjust the inline docs for that function.

Similar to what has been done for the documentation of the get_posts() function, that's a wrapper for a WP_Query object.

Code reference:

get_sites():

https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/ms-blogs.php#L588

WP_Site_Query:

https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/class-wp-site-query.php#L105

get_posts():

https://core.trac.wordpress.org/browser/tags/4.8/src/wp-includes/post.php#L1646

Related #42117

[birgire]

I think this would be a good-first-bug, but I can't mark it as such.

[felipeelia]

This is my first contribution, so please tell me if I'm doing something wrong :)

[birgire]

Thanks for the patch @felipeelia

That looks good to me - I'm just wondering if we should keep it in one line, instead of two.

Wasn't there any recommended maximum length of comments? It would be informative to check that.

[felipeelia]

Thanks @birgire!

I found a recommendation ​here. It can be 120 characters wide, maintaining it in one line we get just 108 (with indentation).

[DrewAPicture]

Hi @felipeelia, thanks for the patches! I'll review them and get back to you with any feedback I might have.

[desrosj]

Today is 5.8 feature freeze. However, this ticket only touches inline documentation, so it can remain for the time being.

[audrasjb]

This needs to be refreshed as get_sites() now belongs to wp-includes/ms-site.php :)

[audrasjb]

patch refreshed against trunk

[SergeyBiryukov]

In 51184:

Docs: Add a reference to WP_Site_Query::__construct() for information on accepted arguments in get_sites().

Synchronize the documentation between two places, use WP_Site_Query::__construct() as the canonical source.

Follow-up to [37616].

Props birgire, felipeelia, audrasjb.
Fixes #42156.