WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 3 months ago

#42158 new enhancement

Twenty Seventeen: RSS Social Icon Missing

Reported by: Kimball31 Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: template Cc:

Description

The RSS icon was available in https://wordpress.com/theme/twentysixteen but is missing from https://codex.wordpress.org/Twenty_Seventeen. Using TwentySeventeen you will get a link/chain icon.

It looks like we only need to add 1) '/feed' => 'rss', to the $social_links_icons array, and 2) an RSS symbol to svg-icons.svg.

I have never contributed before, but I'm willing to add an RSS icon, if this is something you want.

Attachments (1)

42158.diff (1.5 KB) - added by jasonlcrane 4 months ago.

Download all attachments as: .zip

Change History (7)

#1 @Christian Ries
4 months ago

Yes this would be very useful. please do this asap. I don't understand why it is possible to leave this icon away anyway, it must have been forgotten. Thank you very much in advance, Christian

#2 @Christian Ries
4 months ago

Here is the solution: Add this code below <defs> on top of the svg-icons.svg file in the folder wp-content/themes/twentyseventeen/assets/images:

<symbol id="icon-feed" viewBox="0 0 256 256">
<circle cx="68" cy="189" r="24" fill="#FFF"/>
<path class="path1" d="M160 213h-34a82 82 0 0 0 -82 -82v-34a116 116 0 0 1 116 116z
M184 213A140 140 0 0 0 44 73 V 38a175 175 0 0 1 175 175z"></path>
</symbol>

Add this line in the array $social_links_icons at the bottom of the file icon-functions.php in the folder wp-content/themes/twentyseventeen/inc

'/feed'           => 'feed',

That's it. :-) Christian

#3 @SergeyBiryukov
4 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 5.0

@jasonlcrane
4 months ago

#4 @jasonlcrane
4 months ago

The patch above has @Kimball31 and @Christian Ries' suggested fixes.

#5 @jasonlcrane
4 months ago

  • Keywords has-patch added

#6 @jasonlcrane
3 months ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.