Opened 7 years ago
Closed 7 years ago
#42161 closed defect (bug) (fixed)
i18n: Use %s placeholders in translation strings (wp-admin/setup-config.php)
Reported by: | ramiy | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
This patch replaces wp-config.php
with %s
in translation strings. This way the file name can't be mistakenly changes by the translator (this is the best practice).
I also added <code>
tag around the file name.
Attachments (3)
Change History (11)
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
7 years ago
#5
@
7 years ago
- Keywords needs-testing added
I've updated the patch because the last two changes are fine as they are already and the wording itself doesn't need to be changed - the file names just need to be used as placeholders.
#6
@
7 years ago
@danieltj other translation strings that display filenames using %s
placeholders are usually use <code>
tags to emphasize the file, not apostrophes. Just saying...
If we are already fixing those strings, let's apply all the accepted conventions - %s
placeholders, translators comments, HTML tags etc.
I should say that the other translation strings in the file use
%s
and the file names use<code>
HTML tags.