WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 8 weeks ago

Last modified 8 weeks ago

#42165 closed enhancement (fixed)

String "Schedule" should have different context for scheduled post and scheduled customizer changes

Reported by: Mirucon Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

For now, the string 'schedule' is used for both - to schedule a post, and to schedule customizer changes. However, I think their contexts are quite different.

For the post one, it means to schedule a post to publish it, by contrast, for the customizer one, it means that to schedule the changes to publish. They actually have difference, and even if it works in English, it doesn't mean that works in other languages. It should also be considered with different languages.

It'd be good if they have different contexts with _x() function, like I've done in the patch.

Attachments (3)

42165.patch (1.4 KB) - added by Mirucon 2 months ago.
current schedule button.jpg (24.3 KB) - added by mayukojpn 2 months ago.
Current "Schedule" button
42165.1.diff (1.8 KB) - added by Mirucon 2 months ago.

Download all attachments as: .zip

Change History (21)

@Mirucon
2 months ago

#1 @miyauchi
2 months ago

+1

In this case, schedule should be translated into different words depending on the context in Japanese.
For example, the schedule in the post is being translated to 予約投稿 now, but the same word in the theme customizer should be going to be translated to the 予約 or so in Japanese.

#2 @mayukojpn
2 months ago

I don't think translations for this string itself should be changed by objects - it had to be "公開予約" (Schedule publish) rather than "予約投稿" (Schedule post).

@mayukojpn
2 months ago

Current "Schedule" button

#3 @mayukojpn
2 months ago

  • Component changed from General to I18N
  • Keywords 2nd-opinion added

#4 @westonruter
2 months ago

  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


2 months ago

#8 @melchoyce
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.


2 months ago

#10 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41898:

I18N: Add a context for "Schedule" string.

Props Mirucon.
Fixes #42165.

#11 @ocean90
2 months ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

status is the wrong context because it's not a status, it's an action/button label. Scheduled is the status.

#12 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41905:

I18N: Make context for "Schedule" string added in [41898] more accurate.

Props ocean90.
Fixes #42165.

@Mirucon
2 months ago

#14 @Mirucon
2 months ago

  • Keywords has-patch added; needs-patch removed

Thanks for pointing that out @ocean90.

Here's my new patch fixed some strings that need to have contexts.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 weeks ago

#16 @SergeyBiryukov
8 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42005:

I18N: Add a context for remaining "Schedule" strings.

Props Mirucon.
Fixes #42165.

#17 @SergeyBiryukov
8 weeks ago

There are still some "Scheduled" strings left without a context, but they should be handled in #14981.

#18 @Mirucon
8 weeks ago

Thanks @SergeyBiryukov.

That is all that the Japanese translation team wants to change!

Note: See TracTickets for help on using tickets.