#42165 closed enhancement (fixed)
String "Schedule" should have different context for scheduled post and scheduled customizer changes
Reported by: | Mirucon | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | 4.9 |
Component: | I18N | Keywords: | has-patch |
Focuses: | Cc: |
Description
For now, the string 'schedule' is used for both - to schedule a post, and to schedule customizer changes. However, I think their contexts are quite different.
For the post one, it means to schedule a post to publish it, by contrast, for the customizer one, it means that to schedule the changes to publish. They actually have difference, and even if it works in English, it doesn't mean that works in other languages. It should also be considered with different languages.
It'd be good if they have different contexts with _x() function, like I've done in the patch.
Attachments (3)
Change History (21)
#2
@
7 years ago
I don't think translations for this string itself should be changed by objects - it had to be "公開予約" (Schedule publish) rather than "予約投稿" (Schedule post).
This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.
7 years ago
This ticket was mentioned in Slack in #core by melchoyce. View the logs.
7 years ago
This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.
7 years ago
#11
@
7 years ago
- Keywords needs-patch added; 2nd-opinion removed
- Resolution fixed deleted
- Status changed from closed to reopened
status
is the wrong context because it's not a status, it's an action/button label. Scheduled
is the status.
#13
@
7 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
There are now 7 occurrences of "Scheduled" and 2 of "Schedule" without a context, see https://translate.wordpress.org/projects/wp/dev/admin/de/default?filters%5Bterm%5D=Schedule&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Bcase_sensitive%5D=yes and https://translate.wordpress.org/projects/wp/dev/de/default?filters%5Bterm%5D=Schedule&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Bcase_sensitive%5D=yes.
#14
@
7 years ago
- Keywords has-patch added; needs-patch removed
Thanks for pointing that out @ocean90.
Here's my new patch fixed some strings that need to have contexts.
+1
In this case,
schedule
should be translated into different words depending on the context in Japanese.For example, the
schedule
in the post is being translated to予約投稿
now, but the same word in the theme customizer should be going to be translated to the予約
or so in Japanese.