WordPress.org

Make WordPress Core

Opened 9 days ago

Closed 11 hours ago

#42165 closed enhancement (fixed)

String "Schedule" should have different context for scheduled post and scheduled customizer changes

Reported by: Mirucon Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: trunk
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

For now, the string 'schedule' is used for both - to schedule a post, and to schedule customizer changes. However, I think their contexts are quite different.

For the post one, it means to schedule a post to publish it, by contrast, for the customizer one, it means that to schedule the changes to publish. They actually have difference, and even if it works in English, it doesn't mean that works in other languages. It should also be considered with different languages.

It'd be good if they have different contexts with _x() function, like I've done in the patch.

Attachments (2)

42165.patch (1.4 KB) - added by Mirucon 9 days ago.
current schedule button.jpg (24.3 KB) - added by mayukojpn 8 days ago.
Current "Schedule" button

Download all attachments as: .zip

Change History (14)

@Mirucon
9 days ago

#1 @miyauchi
9 days ago

+1

In this case, schedule should be translated into different words depending on the context in Japanese.
For example, the schedule in the post is being translated to 予約投稿 now, but the same word in the theme customizer should be going to be translated to the 予約 or so in Japanese.

#2 @mayukojpn
8 days ago

I don't think translations for this string itself should be changed by objects - it had to be "公開予約" (Schedule publish) rather than "予約投稿" (Schedule post).

@mayukojpn
8 days ago

Current "Schedule" button

#3 @mayukojpn
8 days ago

  • Component changed from General to I18N
  • Keywords 2nd-opinion added

#4 @westonruter
8 days ago

  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.


8 days ago

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


7 days ago

#8 @melchoyce
7 days ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.


20 hours ago

#10 @SergeyBiryukov
11 hours ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41898:

I18N: Add a context for "Schedule" string.

Props Mirucon.
Fixes #42165.

#11 @ocean90
11 hours ago

  • Keywords needs-patch added; 2nd-opinion removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

status is the wrong context because it's not a status, it's an action/button label. Scheduled is the status.

#12 @SergeyBiryukov
11 hours ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41905:

I18N: Make context for "Schedule" string added in [41898] more accurate.

Props ocean90.
Fixes #42165.

Note: See TracTickets for help on using tickets.