Opened 8 years ago
Closed 8 years ago
#42172 closed defect (bug) (fixed)
Customize: Mobile preview button position moves when opening panel and falls out of place in Safari 375px viewport
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | commit |
Focuses: | Cc: |
Description
I don't think the Preview button should be shifting position. In Safari the shifting position then also causes it to fall out of the customize-header-actions when a panel is open.
Demo video: https://youtu.be/pXcS_65BTak
Attachments (2)
Change History (11)
#4
@
8 years ago
I think this issue started after we tried to add animation to those header buttons by overriding position: absolute
. I saw one more issue with animation that the preview button was going away diagonally. Please see if my patch fixes the issue.
#5
@
8 years ago
@Mahvash Fatima Awesome, thanks for participating, I think that was the issue, the patch looks good to me 👍
Tested and is working fine on safari and firefox as well. Lets wait for @westonruter 's feedback.
#6
@
8 years ago
@sayedwp @Mahvash-Fatima The selector *:not(.customize-controls-close)
I expect to be very expensive. Can that be left unchanged?
@sayedwp Any ideas on this one?