Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#42172 closed defect (bug) (fixed)

Customize: Mobile preview button position moves when opening panel and falls out of place in Safari 375px viewport

Reported by: westonruter's profile westonruter Owned by: westonruter's profile westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: commit
Focuses: Cc:

Description

I don't think the Preview button should be shifting position. In Safari the shifting position then also causes it to fall out of the customize-header-actions when a panel is open.

Demo video: https://youtu.be/pXcS_65BTak

Attachments (2)

42172.diff (1.3 KB) - added by Mahvash Fatima 8 years ago.
42172.1.diff (1.2 KB) - added by Mahvash Fatima 8 years ago.

Download all attachments as: .zip

Change History (11)

#1 @westonruter
8 years ago

  • Keywords needs-patch added

@sayedwp Any ideas on this one?

#2 @sayedwp
8 years ago

Have not seen that before, I will check when I am back on my desk tomorrow.

#3 @melchoyce
8 years ago

  • Owner set to sayedwp
  • Status changed from new to assigned

#4 @Mahvash Fatima
8 years ago

I think this issue started after we tried to add animation to those header buttons by overriding position: absolute . I saw one more issue with animation that the preview button was going away diagonally. Please see if my patch fixes the issue.

@Mahvash Fatima
8 years ago

#5 @sayedwp
8 years ago

@Mahvash Fatima Awesome, thanks for participating, I think that was the issue, the patch looks good to me 👍
Tested and is working fine on safari and firefox as well. Lets wait for @westonruter 's feedback.

#6 @westonruter
8 years ago

@sayedwp @Mahvash-Fatima The selector *:not(.customize-controls-close) I expect to be very expensive. Can that be left unchanged?

#7 @Mahvash Fatima
8 years ago

Sure, please find attached patch.

#8 @westonruter
8 years ago

  • Keywords commit added; needs-patch removed
  • Owner changed from sayedwp to westonruter
  • Status changed from assigned to accepted

Works great!

#9 @westonruter
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41853:

Customize: Fix positioning of Preview button in mobile.

Props Mahvash-Fatima.
Fixes #42172.

Note: See TracTickets for help on using tickets.