WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42189, comment 7


Ignore:
Timestamp:
10/12/2017 10:45:16 AM (3 years ago)
Author:
rafa8626
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42189, comment 7

    initial v1  
    1 @bradyvercher I see. That's where my knowledge on WP is limited. I agree with @ocean90 idea, and the PR I created contain must of the things you have listed. Last night, I updated MEJS to include a new method to override the issue with the features, so if the plan is to add a new JS just make sure that MEJS matches with the version of that PR. The `<mediaelement>` wrapper is needed since it's the fake node that allows all the other renderers to mimic the API, so that cannot change; to access the original tag, you have to use media.originalNode. Let me know if there's anything else I can help you, other than updating the PR as a baseline for the potential `mediaelement-migrate.js` file
     1@bradyvercher I see. That's where my knowledge on WP is limited. I agree with @ocean90 idea, and the PR I created contain must of the things you have listed. Last night, I updated MEJS to include a new method to override the issue with the features, so if the plan is to add a new JS just make sure that MEJS matches with the version of that PR. The `<mediaelement>` wrapper is needed since it's the fake node that allows all the other renderers to mimic the API, so that cannot be changed on my side; to access the original tag, you have to use media.originalNode. The other variable that I cannot change is `player.container`, given that is being used in lots of places.
     2
     3Let me know if there's anything else I can help you, other than updating the PR as a baseline for the potential `mediaelement-migrate.js` file