WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#42190 closed defect (bug) (fixed)

Avoid punctuation inside a html link

Reported by: Presskopp Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

.. to be different from your WordPress installation directory</a>.

instead of

.. to be different from your WordPress installation directory.</a>

please!

Trying to find a good argument I found something here:
https://ux.stackexchange.com/questions/17331/should-a-full-sentence-html-link-include-the-period-in-the-linked-text

I scanned all WP files and I found it only there.

Attachments (1)

42190.diff (1.1 KB) - added by Presskopp 4 years ago.

Download all attachments as: .zip

Change History (5)

@Presskopp
4 years ago

#1 @Presskopp
4 years ago

  • Keywords has-patch added

#2 @swissspidy
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.9

This is the only string in core where the punctuation mark is within the link instead of after.

#3 @SergeyBiryukov
4 years ago

  • Component changed from General to Administration

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41874:

Administration: Remove punctuation from the link text in "Site Address" option description.

Props Presskopp.
Fixes #42190.

Note: See TracTickets for help on using tickets.