WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#42192 closed defect (bug) (wontfix)

Reference to third person in one phrase should be consistent in class-wp-customize-manager.php

Reported by: tobifjellner Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: reporter-feedback close has-patch
Focuses: Cc:
PR Number:

Description

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-manager.php>
Contains (from https://core.trac.wordpress.org/changeset/41839/ )

The following phrase:

%s is already customizing this site. Please wait until they are done to try customizing. Your latest changes have been autosaved.

I suggest changing to:
%s is already customizing this site. Please wait until the other person is ready before you try customizing. Your latest changes have been autosaved.

Current code snippet for reference:

<?php
/* translators: %s: User who is customizing the changeset in customizer. */
printf( __( '%s is already customizing this site. Please wait until they are done to try customizing. Your latest changes have been autosaved.' ), '{{ data.lockUser.name }}' );
?>

Attachments (1)

42192.diff (830 bytes) - added by danieltj 2 years ago.
Updated translation string

Download all attachments as: .zip

Change History (6)

#1 @ocean90
2 years ago

  • Keywords reporter-feedback added
  • Summary changed from Reference to thirs person in one phrase should be consistent in class-wp-customize-manager.php to Reference to third person in one phrase should be consistent in class-wp-customize-manager.php

Why would this be consistent? "They" is used to avoid specifying the gender of the person.

@danieltj
2 years ago

Updated translation string

#2 @danieltj
2 years ago

  • Keywords has-patch added

I've added a patch in which alters the wording in that second sentence. Even forgetting about consistency for a moment, please wait until they are done seems like it could be improved. I've proposed the following change in 42192.diff.

%s is already customizing this site. Please wait until the other person is finished before you start customizing. Your latest changes have been autosaved.

#3 @swissspidy
2 years ago

  • Keywords close added; has-patch removed

See https://en.wikipedia.org/wiki/Singular_they for an explanation of this form.

#4 @swissspidy
2 years ago

  • Keywords has-patch added

#5 @westonruter
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As a native english speaker, using “they“ here is natural. Switching this to “the other person” sounds a bit out of line with the “howdyness” of WordPress. Clearly other languages will need to translate “they” according to their own grammar rules.

Note: See TracTickets for help on using tickets.