WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#42199 closed defect (bug) (fixed)

Customizer: Using device size controls with changes scheduling panel opens causes resized preview pane to be partially obscured

Reported by: johnpgreen Owned by: sayedwp
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: needs-patch
Focuses: Cc:

Description

Steps to recreate:
1) Navigate to the Customizer
2) Select "Additional CSS"
3) Enter some CSS code to activate the gear button next to the "Publish" button
4) Click the gear button next to the "Publish" button, causing the status panel to slide out
5) Click the tablet or phone icon

Expected result: preview pane resizes within available space
Actual result: preview pane resizes and moves partially behind the Customizer controls

Screenshots coming up.

Attachments (4)

42199-after-step-3.png (1.8 MB) - added by johnpgreen 2 months ago.
Gear button activated after entering CSS
42199-after-step-4.png (880.6 KB) - added by johnpgreen 2 months ago.
Status panel slides out, pushes preview pane to the right
42199-after-step-5-tablet.png (249.9 KB) - added by johnpgreen 2 months ago.
After clicking tablet icon, preview pane resizes and shifts under the Customizer
42199-after-step-5-phone.png (104.9 KB) - added by johnpgreen 2 months ago.
And then clicking the phone icon

Change History (10)

@johnpgreen
2 months ago

Gear button activated after entering CSS

@johnpgreen
2 months ago

Status panel slides out, pushes preview pane to the right

@johnpgreen
2 months ago

After clicking tablet icon, preview pane resizes and shifts under the Customizer

@johnpgreen
2 months ago

And then clicking the phone icon

#1 @westonruter
2 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9

@sayedwp Can you take a look at this? It may be related to #42027 which I committed prior to completion.

#2 @sayedwp
2 months ago

Yes, I reopened #42027 and will fix it along with that.

#3 @melchoyce
2 months ago

  • Owner set to sayedwp
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


2 months ago

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


2 months ago

#6 @westonruter
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41860:

Customize: Fix positioning of device-previewed window when publish settings are open.

  • Update date control padding.
  • Collapse publish settings section when opening panes for available widgets or nav menus.
  • Remove save and cog buttons in mobile preview only mode.
  • Move definition of wp.customize.previewedDevice to wp.customize.state('previewedDevice') for centralization, maintaining old alias.
  • Remove unused CSS because the section is inside form now.

Props sayedwp, westonruter.
See #39896.
Fixes #42027, #42199.

Note: See TracTickets for help on using tickets.