Code Editors: "Help" cursor shows up even when there isn't an error

[melchoyce]

Looks like the hover state is being triggered even when an error or warning isn't visible. See video for details: ​https://cloudup.com/cGLOZtacmg7

[studionashvegas]

Patch for #42210

[studionashvegas]

It looks like the cursor was being applied en masse to the left-hand column reserved for error messages. The first patch is wrong (my mistake) but the second one works to only apply that cursor when an error icon is present.

[studionashvegas]

CORRECT patch to fix help icon on Code Editor

[melchoyce]

Looks good, but the help cursor has been replaced by pointer. Mind swapping that back in?

[studionashvegas]

Absolutely. Patch incoming!

[studionashvegas]

Replaces 'help' with 'pointer', by request

[melchoyce]

Hey @studionashvegas, I think I miscommunicated — I meant that in your original patch, I was seeing pointer when I hovered over the warnings, rather than seeing help. The cursor should be help. I think whatever you were targeting wasn't working correctly in code-editor-help.42210.2.diff​.

[studionashvegas]

That's so weird. I rolled back my commits (which I used to create that patch) and the cursor is indeed help...

I'm not sure why it didn't work, but I wrote -another- patch from scratch (it was only changing one line of CSS) and I'm uploading that again. I tried applying this patch too - it works for me.

~Mitch

[studionashvegas]

Yet Another 42210 Patch That Should Work This Time

[melchoyce]

In 41897:

Code Editors: Fix display of "help" cursor.

Props studionashvegas .
Fixes #42210.