WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#42211 closed defect (bug) (fixed)

Customizer: Scheduling: Delay button shake

Reported by: melchoyce Owned by: bpayton
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

The "Schedule" button currently shakes immediately after selecting "Schedule" in Publish Settings, but there should be a delay. Right now it's drawing attention away from actually setting a time to schedule your changes to go live. I don't think we should shake the button until after the Publish Settings panel has been closed, maybe with a second's delay.

Change History (6)

#1 @melchoyce
4 years ago

  • Owner set to bpayton
  • Status changed from new to assigned

#2 @bpayton
4 years ago

  • Keywords has-patch added; needs-patch removed

I have a patch for this based on work for #42114 (which includes a reusable function for bouncing things after a delay if they aren't focused first). I'm managing the work under a single PR for discussion since there is shared, unreviewed code.
https://github.com/xwp/wordpress-develop/pull/284

I'll continue discussion under #42114 and provide a separate patch here if necessary.

#3 @westonruter
4 years ago

@bpayton with #42114 merged, this is ready to round out.

#4 @bpayton
4 years ago

@westonruter, I created a PR since we've worked well with them. It is ready for review here:
https://github.com/xwp/wordpress-develop/pull/291

#5 @westonruter
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41932:

Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.

Props bpayton, westonruter.
See #42114, #39896.
Fixes #42211.

#6 @westonruter
4 years ago

In 41947:

Customize: Prevent drawing attention to save button if status unchanged from publish; account for changes to status/date when alerting about unsaved changes.

Also fix malformed ESLint directive from [41933].

Amends [41932].
See #39896, #42211.

Note: See TracTickets for help on using tickets.