#42223 closed defect (bug) (fixed)
Merge two similar translation strings when using get_space_allowed()
Reported by: | ramiy | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch has-screenshots needs-refresh |
Focuses: | multisite | Cc: |
Description
Both multisite_over_quota_message()
and upload_is_user_over_quota()
output similar error messages when the passing the allowed storage quota. The first is for multisite and the second is for the media library, but both functions use get_space_allowed()
.
Sorry, you have used all of your storage quota of %s MB.
Sorry, you have used your space allocation. Please delete some files to upload more files.
Those two messages can be merged into one:
Sorry, you have used your space allocation of %s MB. Please delete some files to upload more files.
Attachments (5)
Change History (16)
#2
@
7 years ago
We can also merge the string used in the deprecated wpmu_checkAvailableSpace()
function.
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
7 years ago
#4
@
7 years ago
- Milestone changed from Awaiting Review to 5.0
A similar string is also used in wp_xmlrpc_server::mw_newMediaObject()
.
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
7 years ago
#8
@
6 years ago
- Keywords needs-refresh added
- Milestone changed from 5.1 to 5.2
Instead of %s MB
, this would probably be better if we took the return value of get_space_used()
, multiply it by MB_IN_BYTES
, and feed that number to size_format()
. Given that sites have fairly large size limits these days, limiting it to MB is going to make for some large numbers.
#9
@
6 years ago
@pento
For now we can use %s
placeholder in the translation string.
Later, if we will decide to change the value, it won't affect the translation string.
Add translators comments