WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 10 days ago

#42223 new defect (bug)

Merge two similar translation strings when using get_space_allowed()

Reported by: ramiy Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch has-screenshots
Focuses: multisite Cc:

Description

Both multisite_over_quota_message() and upload_is_user_over_quota() output similar error messages when the passing the allowed storage quota. The first is for multisite and the second is for the media library, but both functions use get_space_allowed().

  1. Sorry, you have used all of your storage quota of %s MB.
  1. Sorry, you have used your space allocation. Please delete some files to upload more files.

Those two messages can be merged into one:

  • Sorry, you have used your space allocation of %s MB. Please delete some files to upload more files.

Attachments (5)

42223.png (20.0 KB) - added by ramiy 8 months ago.
42223.patch (1.1 KB) - added by ramiy 8 months ago.
42223.2.patch (1.2 KB) - added by ramiy 8 months ago.
Add translators comments
42223-3.patch (357.3 KB) - added by Jonathandejong 10 days ago.
42223-4.patch (1.3 KB) - added by Jonathandejong 10 days ago.
fixes -3.patch

Download all attachments as: .zip

Change History (11)

@ramiy
8 months ago

@ramiy
8 months ago

#1 @ramiy
8 months ago

  • Focuses multisite added
  • Keywords has-patch has-screenshots added

@ramiy
8 months ago

Add translators comments

#2 @ramiy
8 months ago

We can also merge the string used in the deprecated wpmu_checkAvailableSpace() function.

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


8 months ago

#4 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 5.0

A similar string is also used in wp_xmlrpc_server::mw_newMediaObject().

This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.


7 months ago

#6 @Jonathandejong
10 days ago

Apologies, added a bit too much.. new patch coming right up.

@Jonathandejong
10 days ago

fixes -3.patch

Note: See TracTickets for help on using tickets.