WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#42236 closed defect (bug) (fixed)

CSS active class color do not update with chosen color scheme

Reported by: sayedwp Owned by: helen
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.4
Component: General Keywords: has-patch needs-testing commit
Focuses: ui Cc:
PR Number:

Description (last modified by westonruter)

When the publish settings section opens, an active class is applied to it. And when the color scheme changes, the color should change by the color scheme.

https://user-images.githubusercontent.com/6297436/31604308-8a9b5144-b280-11e7-938f-f6fcb86936b4.png

The same thing would happen if we add active class to any button in WordPress admin.

https://user-images.githubusercontent.com/6297436/31604551-4eb5e698-b281-11e7-9fce-e2ad8f06875c.png

Originally: Please see https://core.trac.wordpress.org/ticket/39896#comment:115

Attachments (1)

42236.diff (504 bytes) - added by helen 2 years ago.

Download all attachments as: .zip

Change History (11)

#1 @westonruter
2 years ago

  • Description modified (diff)
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9
  • Owner set to helen
  • Status changed from new to assigned
  • Version changed from 4.8.2 to 4.4

@helen It looks like maybe this is something that was missed in [34948]?

#2 @westonruter
2 years ago

  • Description modified (diff)

@helen
2 years ago

#3 @helen
2 years ago

I guess this is the first time we're actually using that .active class for something besides documentation. 42236.diff fixes it for me in core's color schemes - not sure what people are doing to generate custom ones, and I believe a number of plugins will need to be updated accordingly. So, testing and feedback appreciated.

#4 @melchoyce
2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 @sayedwp
2 years ago

Looking good now 👍

Without focus and active class:

https://user-images.githubusercontent.com/6297436/31784350-fe2d6db8-b51e-11e7-83f4-93552d15ff92.png

With Focus and active class:

https://user-images.githubusercontent.com/6297436/31784246-9f05cbe6-b51e-11e7-810a-0eba3913e631.png

#6 @sayedwp
2 years ago

Changing color as expected.

https://user-images.githubusercontent.com/6297436/31784462-5c7acf0a-b51f-11e7-9836-7d15d47585e8.png

This ticket was mentioned in Slack in #core-customize by sayedwp. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 years ago

#9 @westonruter
2 years ago

  • Keywords commit added

#10 @helen
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41984:

Buttons: Ensure active styling applies to both :active and .active.

props sayedwp, helen.
fixes #42236.

Note: See TracTickets for help on using tickets.