WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #42254, comment 5


Ignore:
Timestamp:
10/25/2017 12:31:13 PM (2 years ago)
Author:
Iceable
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42254, comment 5

    initial v1  
    11Agreed on keeping it dry.
    2 It would broaden the scope of this ticket, but would make sense if {{{ wp_widget_rss_output() }}} itself was able to avoid duplicates.
    32
    4 I'd say introducing this ability directly in this function with a new argument sounds good - if we can do it without affecting other areas where it is used.
     3~~It would broaden the scope of this ticket, but would make sense if {{{ wp_widget_rss_output() }}} itself was able to avoid duplicates.~~
     4
     5~~I'd say introducing this ability directly in this function with a new argument sounds good - if we can do it without affecting other areas where it is used.~~
     6
     7I just realised `wp_widget_rss_output()` only takes one feed at a time (and is currently called once for each feed).
     8So abstracting the main part to reduce duplicate code and creating a new function to display the result from multiple feeds without duplicates sounds good.
    59
    610Changing the feeds in use would easily get rid of the issue without affecting anything else, but why just circumvent the issue if we can effectively improve and future-proof the function that handles this?