Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#42275 closed defect (bug) (fixed)

Customize, Activate and Live Preview button are not aligned properly on themes page under apperance

Reported by: sayedwp's profile sayedwp Owned by: westonruter's profile westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Themes Keywords: has-patch
Focuses: ui, administration Cc:


Attachments (2)

42275.diff (455 bytes) - added by Mirucon 7 years ago.
42275.1.diff (11.2 KB) - added by Mahvash Fatima 7 years ago.

Download all attachments as: .zip

Change History (14)

#1 @ocean90
7 years ago

  • Component changed from General to Themes
  • Focuses administration added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9

#2 follow-up: @melchoyce
7 years ago

This is a recent regression. Can we track down where it was introduced?

#3 @melchoyce
7 years ago

#42279 was marked as a duplicate.

7 years ago

#4 @Mirucon
7 years ago

  • Keywords has-patch added; needs-patch removed

Here's my patch from #42279

#5 @sayedwp
7 years ago

This will break the customizer theme's panel buttons because they both share the common css, I think this is regression from #42215 @mahvash-fatima can you take a look

#6 @Mahvash Fatima
7 years ago

Ah, I was not aware that the same css is applied in Appearance > Themes as well, working to fix.

BTW the same button vertical alignment issue already exists for themes page as well for small screen.

#7 in reply to: ↑ 2 @jcastaneda
7 years ago

Replying to melchoyce:

This is a recent regression. Can we track down where it was introduced?

From what I was able to find it was introduced in [41893]

#8 @Mahvash Fatima
7 years ago

About the changes.

1- Moved my CSS added in #42215 in customize-controls.css to themes.css so it can be used at both the places.
2 - Added some css for button for bigger screen.
3- Add wrapper div around the theme action elements so its properly structured, and easy to align. ( No other changes in the markup ) just the way it was done in #42215

#9 @melchoyce
7 years ago

Looks like that fixed it, thanks @Mahvash Fatima 👍

@westonruter would you mind giving it a quick review?

#10 @melchoyce
7 years ago

  • Owner set to westonruter
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-customize by sayedwp. View the logs.

7 years ago

#12 @westonruter
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41949:

Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen.

Amends [41893].
Props Mahvash-Fatima.
See #42215.
Fixes #42275.

Note: See TracTickets for help on using tickets.