WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#42286 closed defect (bug) (fixed)

Options missing from select controls in the customizer

Reported by: bradyvercher Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

Select controls in the customizer aren't being populated with any options. To replicate, check the color scheme controls in Twenty Fifteen and Twenty Sixteen.

Change History (5)

#1 @westonruter
22 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.9

@bradyvercher Thanks for reporting. Would you please test this patch? https://core.trac.wordpress.org/attachment/ticket/30738/30738.4.diff

#2 @bradyvercher
22 months ago

@westonruter I was thinking the choices needed to be exported in WP_Customize_Control::to_json(), but that patch looks like it works as well.

#3 @westonruter
22 months ago

@bradyvercher yeah, it is omitted from the json for now. Exporting the choices was explored in #30738 but it got punted to probably land in 5.0 via #30738 where we'll opt to use the JS templates for rendering all of the base controls.

#4 @westonruter
22 months ago

  • Owner set to westonruter
  • Resolution set to fixed
  • Status changed from new to closed

In 41952:

Customize: Prevent using default template for a base control when it has content rendered on the server.

Also prevent invalid type attribute from being added to a select element.

See #30738.
Fixes #42286.

#5 @westonruter
22 months ago

#42293 was marked as a duplicate.

Note: See TracTickets for help on using tickets.