WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#42290 closed defect (bug) (fixed)

Use typographical quotation marks in echoed text in class-wp-customize-nav-menus.php

Reported by: tobifjellner Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Menus Keywords: has-patch
Focuses: Cc:

Description

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-customize-nav-menus.php?marks=949#L949

<p id="customize-new-menu-submit-description"><?php _e( 'Click "Next" to start adding links to your new menu.' ); ?></p>

Ought to be

<p id="customize-new-menu-submit-description"><?php _e( 'Click &#8220;Next&#8221; to start adding links to your new menu.' ); ?></p>

Attachments (2)

2131.3.diff (508 bytes) - added by audrasjb 2 years ago.
small patch for this ticket
42290.diff (829 bytes) - added by audrasjb 2 years ago.
The real patch for this ticket

Download all attachments as: .zip

Change History (6)

@audrasjb
2 years ago

small patch for this ticket

#1 @audrasjb
2 years ago

  • Keywords has-patch added

@audrasjb
2 years ago

The real patch for this ticket

#2 @audrasjb
2 years ago

Hi @tobifjellner

Sorry I uploaded the wrong .diff file at first.

42290.diff if the good one, of course :)

Regards,
Jb

#3 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9

#4 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41956:

Customize: Use typographic quotation marks in the strings added in [41768].

Props audrasjb, tobifjellner.
Fixes #42290. See #40104.

Note: See TracTickets for help on using tickets.