WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#42292 closed defect (bug) (duplicate)

avoid double space character in strings

Reported by: Presskopp Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.9
Component: Text Changes Keywords:
Focuses: Cc:

Description

There are some strings containing double spaces:

process. Freshly
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/about.php?marks=138#L138

theme. Additionally
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/about.php?marks=134#L134

drafts, locking [...] links. What’s
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/about.php?marks=53#L53

changes before, you’ll pinpoint, coding errors
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/about.php?marks=107#L107

I also found some in PHP files, do you want me to make another ticket for those, like

' . $origin );
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/http.php?marks=491#L491

Change History (8)

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 4.9

#3 @melchoyce
4 years ago

The about.php ones should hopefully be fixed in https://core.trac.wordpress.org/attachment/ticket/42087/42087.diff — @Presskopp can you double-check when you have a moment?

#4 @Presskopp
4 years ago

No, I found 7 of them - where do they come from? Made a patch at #42087

#5 @melchoyce
4 years ago

Thanks. I copied and pasted the copy from a Slack text snippet.

#6 @Presskopp
4 years ago

FYI: PHP (spacing) issues will be handled in #41057

Last edited 4 years ago by Presskopp (previous) (diff)

#7 @afercia
4 years ago

  • Milestone 4.9 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Seems to me this ticket can be closed, right? All the double spaces within translatable strings will be handled in #42087 and the ones within code fall under the coding standards to address in #41057. /cc @Presskopp @melchoyce Please do feel free to reopen if I'm missing something.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.