#42306 closed defect (bug) (fixed)
Themes: Harmonize list of theme features on Theme Install screen with list in the Customizer
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | 4.9 |
Component: | Themes | Keywords: | |
Focuses: | ui | Cc: |
Description
When the textstrings after the checkbox in the Features box (in: Customizer, Themes, Add New, Feature Filter) become to long, for example after their translation to german, the linebreak gets over 3 lines.
I've marked that blue in the attached screenshot.
Also, some of the orange marked strings are not ready for translation yet, but will probably become quite long in german too.
An indented linebreak over 2 lines after the checkbox would be nice here.
Attachments (4)
Change History (13)
@
7 years ago
Use the core theme features list in wp-admin, as these are the only tags with translations available.
#1
@
7 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 4.9
These strings seem to be missing because they generally duplicate information that should be returned from the WordPress.org API. Apparently the translations were present in core but are not transferred from the API, even though the intent of the relevant functions was for .org to be able to update this list without core changes. We've moved past that concept at this point, and this issue reinforces that core needs its own version of this list distinct from the API (unless the API could be updated to return the translations).
For the customizer, these tags were removed due to being unhelpful in the process of finding a theme. In the process, the translations seem to have been lost for wp-admin, even though wp-admin is still using the tags returned from the API, while the customizer uses the list in core. .org, wp-admin, and the customizer will all be reconciled with a modernized theme browsing experience in a future iteration, based on a joint effort with the themes and meta teams.
The easiest solution at this point for 4.9 would be to use the core features list for wp-admin too, as the .org list is outdated and has usability issues with many of the tags (many are more useful for "internal" purposes but not user-facing). See 42306.diff.
(the line break issue is something that's less critical, and it should only happen for very long strings and at specific screen sizes)
#5
@
7 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from 4.9 to 4.9.1
- Owner westonruter deleted
The line break issue we'll address in a minor release.
#8
@
7 years ago
- Keywords needs-patch removed
- Milestone changed from 4.9.2 to 4.9
- Resolution set to fixed
- Status changed from reviewing to closed
- Summary changed from Add Themes: Features box textstrings in Feature Filter area need new linebreak to Themes: Harmonize list of theme features on Theme Install screen with list in the Customizer
Remaining issues to be addressed in #42871.
Feature Filters